Use intermediate file containing javac arguments to overcome windows limitations

editor/tools/compile_analyzer.py

 #!/usr/bin/env python
 # Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 #
 # Script to compile the analyzer.
 #
 # Usage: compile_analyzer.py OPTIONS files
 #
 
@@ skipping 17 matching lines @@
   options.add_option("--jar_entry_directory",
       help='Which directory within output to pack into the jar files')
   options.add_option("--entry_point",
       help='The entry point for running the program.')
   options.add_option("--dependent_jar_files",
       help='The jar files that we link against, space separated.')
   return options.parse_args()
 
 def CompileAnalyzer(options, args):
   # We rely on all jar files being copied to the output dir.
-  class_path = options.output_dir + '*'
+  if sys.platform == 'win32':
+    class_path = options.output_dir + '*;'
+  else:
+    class_path = options.output_dir + '*'
   cmd = [GetJavacPath(),
          '-sourcepath', 'foobar',
          '-source', '6',
          '-target', '6',
          '-implicit:none',
          '-d', options.output_dir,
          '-cp', class_path,
          ]
   cmd.extend(args)
-  subprocess.call(cmd)
+  exit_code = subprocess.call(cmd)
+  if exit_code:
+    raise Exception("Executing command [%s] failed" % cmd)
 
 def CreateJarFile(options):
   class_path_file_name = options.output_dir + options.class_path_file
   jar_file_name = options.output_dir + options.jar_file_name
   cmd = [GetJarToolPath(), 'cfem', jar_file_name, options.entry_point,
          class_path_file_name,
          '-C', options.output_dir, options.jar_entry_directory]
-  subprocess.call(cmd)
+  exit_code = subprocess.call(cmd)
+  if exit_code:
+    raise Exception("Executing command [%s] failed" % cmd)
 
 def CopyFiles(options):
   # Strip " from the string
   files = options.dependent_jar_files.replace('"', '')
   for f in files.split(" "):
     shutil.copy(f, options.output_dir)
 
 def CreateClassPathFile(options):
   class_path_file_name = options.output_dir + options.class_path_file
   with open(class_path_file_name, 'w') as output:
@@ skipping 32 matching lines @@
   os.makedirs(options.output_dir)
 
   CopyFiles(options)
   CreateClassPathFile(options)
   CompileAnalyzer(options, args)
   CreateJarFile(options)
 
 
 if __name__=='__main__':
   main()