Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 1398193002: Revert of SkPDF: Optionally output PDF/A-2b archive format. (Closed)

Created:
5 years, 2 months ago by bungeman-skia
Modified:
5 years, 2 months ago
Reviewers:
hal.canary, tomhudson
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of SkPDF: Optionally output PDF/A-2b archive format. (patchset #5 id:80001 of https://codereview.chromium.org/1394263003/ ) Reason for revert: SkMD5 is not really part of the Skia library. This is breaking the roll by using it, since Chromium doesn't build it. Original issue's description: > SkPDF: Optionally output PDF/A-2b archive format. > > Note: this format does not yet pass validation tests. > > Add skia_pdf_generate_pdfa GYP flag. Default to off for now. > PDF/A files are not reproducable, so they make correctness > testing harder. > > Turn the Metadata struct into te SkPDFMetadata struct. This > splits out a lot of functionality around both kinds of metadata. > > When PDF/A is used, add an ID entry to the trailer. > > Add SkPDFObjNumMap::addObjectRecursively. > > Test with > > GYP_DEFINES=skia_pdf_generate_pdfa=1 bin/sync-and-gyp > ninja -C out/Release dm > out/Release/dm --config pdf --src skp gm -w /tmp/dm > > With skia_pdf_generate_pdfa=0, all PDFs generated from GMs and > SKPs are identical. With skia_pdf_generate_pdfa=1, all PDFs > generated from GMs and SKPs render identically in Pdfium. > > BUG=skia:3110 > > Committed: https://skia.googlesource.com/skia/+/939c0fe51f157104758bcb268643c8b6d317a530 TBR=tomhudson@google.com,halcanary@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:3110 Committed: https://skia.googlesource.com/skia/+/21f99b7733c5d468deee9f8dadd59e77ed33d5ca

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -448 lines) Patch
M gyp/common_variables.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M gyp/pdf.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M gyp/pdf.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M src/doc/SkDocument_PDF.cpp View 7 chunks +67 lines, -43 lines 0 comments Download
M src/pdf/SkPDFBitmap.cpp View 1 chunk +8 lines, -6 lines 0 comments Download
D src/pdf/SkPDFMetadata.h View 1 chunk +0 lines, -34 lines 0 comments Download
D src/pdf/SkPDFMetadata.cpp View 1 chunk +0 lines, -347 lines 0 comments Download
M src/pdf/SkPDFTypes.h View 1 chunk +0 lines, -6 lines 0 comments Download
M src/pdf/SkPDFTypes.cpp View 2 chunks +3 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
bungeman-skia
Created Revert of SkPDF: Optionally output PDF/A-2b archive format.
5 years, 2 months ago (2015-10-09 20:45:37 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1398193002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1398193002/1
5 years, 2 months ago (2015-10-09 20:45:43 UTC) #2
commit-bot: I haz the power
5 years, 2 months ago (2015-10-09 20:45:56 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/21f99b7733c5d468deee9f8dadd59e77ed33d5ca

Powered by Google App Engine
This is Rietveld 408576698