Issue 1398133002: Remove stale comment warning about blacklist updates requiring a clobber build

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1398133002: Remove stale comment warning about blacklist updates requiring a clobber build (Closed)

Created:
5 years, 2 months ago by Reid Kleckner

Modified:
5 years, 2 months ago

Reviewers:
Alexander Potapenko

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Remove stale comment warning about blacklist updates requiring a clobber build Add suggestion to use function attributes to disable sanitizer instrumentation, as suggested in https://codereview.chromium.org/1402493002/. R=glider@chromium.org NOTRY=true Committed: https://crrev.com/3f5522e88d880c14e9e090c510200ae8169bb493 Cr-Commit-Position: refs/heads/master@{#353344}

Patch Set 1 #

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -12 lines)			Patch
M	tools/memory/asan/blacklist.txt	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	tools/memory/asan/blacklist_win.txt	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	tools/memory/tsan_v2/ignores.txt	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	tools/msan/blacklist.txt	View	1 chunk	+2 lines, -3 lines	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1398133002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1398133002/1

5 years, 2 months ago (2015-10-09 18:44:06 UTC) #4

commit-bot: I haz the power

5 years, 2 months ago (2015-10-09 18:56:47 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/3f5522e88d880c14e9e090c510200ae8169bb493
Cr-Commit-Position: refs/heads/master@{#353344}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages