Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 139813003: Move isValid implementations into SVGGraphicsElement (Closed)

Created:
6 years, 11 months ago by rwlbuis
Modified:
6 years, 11 months ago
Reviewers:
pdr., Stephen Chennney
CC:
blink-reviews, pdr, Stephen Chennney, krit, f(malita), rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Move isValid implementations into SVGGraphicsElement All subclasses share the same implementation, so provide it in SVGGraphicsElement. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165175

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -24 lines) Patch
M Source/core/svg/SVGAElement.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/svg/SVGCircleElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGClipPathElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGDefsElement.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/svg/SVGDefsElement.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/svg/SVGEllipseElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGForeignObjectElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGGElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGGraphicsElement.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/svg/SVGImageElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGLineElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGPathElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGPolyElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGRectElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGSVGElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGSwitchElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGTextContentElement.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/svg/SVGUseElement.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
rwlbuis
Simple refactor.
6 years, 11 months ago (2014-01-15 20:41:11 UTC) #1
Stephen Chennney
lgtm
6 years, 11 months ago (2014-01-15 20:51:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/139813003/1
6 years, 11 months ago (2014-01-15 21:08:53 UTC) #3
commit-bot: I haz the power
6 years, 11 months ago (2014-01-16 00:00:50 UTC) #4
Message was sent while issue was closed. 
Change committed as 165175

Powered by Google App Engine
This is Rietveld 408576698