Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1042)

Unified Diff: third_party/WebKit/Source/modules/presentation/Presentation.h

Issue 1398103002: Oilpan: fix build after r353269. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/presentation/Presentation.h
diff --git a/third_party/WebKit/Source/modules/presentation/Presentation.h b/third_party/WebKit/Source/modules/presentation/Presentation.h
index 10a940b21938c0aa5ea1f3ac75fb42779be5fa64..5ab715fa229e64454e4514b7907812750a05c3e0 100644
--- a/third_party/WebKit/Source/modules/presentation/Presentation.h
+++ b/third_party/WebKit/Source/modules/presentation/Presentation.h
@@ -17,6 +17,8 @@ class PresentationRequest;
// Implements the main entry point of the Presentation API corresponding to the Presentation.idl
// See https://w3c.github.io/presentation-api/#navigatorpresentation for details.
+//
+// TODO(Oilpan): switch to GarbageCollected<Presentation> once object is unconditionally on the Oilpan heap.
class Presentation final
: public GarbageCollectedFinalized<Presentation>
, public ScriptWrappable
@@ -25,7 +27,9 @@ class Presentation final
DEFINE_WRAPPERTYPEINFO();
public:
static Presentation* create(LocalFrame*);
+#if !ENABLE(OILPAN)
~Presentation() override = default;
+#endif
DECLARE_VIRTUAL_TRACE();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698