Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 1398043006: Revert server test extension manager "fix" [TBR]. (Closed)

Created:
5 years, 2 months ago by pquitslund
Modified:
5 years, 2 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert server test extension manager "fix". BUG= Committed: https://github.com/dart-lang/sdk/commit/9989687a2599c566d376967753992ef5e5481927

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -7 lines) Patch
M pkg/analysis_server/test/analysis_server_test.dart View 1 chunk +2 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
pquitslund
Backing out of this hasty fix. Breaks things BADLY.
5 years, 2 months ago (2015-10-15 05:10:28 UTC) #1
pquitslund
5 years, 2 months ago (2015-10-15 05:10:36 UTC) #3
pquitslund
Committed patchset #1 (id:1) manually as 9989687a2599c566d376967753992ef5e5481927 (presubmit successful).
5 years, 2 months ago (2015-10-15 05:10:53 UTC) #4
scheglov
LGTM
5 years, 2 months ago (2015-10-15 13:53:10 UTC) #5
Brian Wilkerson
5 years, 2 months ago (2015-10-15 13:58:01 UTC) #7
Message was sent while issue was closed.
LGTM, but I'd like to understand why this change broke the tests.

Powered by Google App Engine
This is Rietveld 408576698