Issue 1398033004: One extension manager (to bind them all).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1398033004: One extension manager (to bind them all). (Closed)

Created:
5 years, 2 months ago by pquitslund

Modified:
5 years, 2 months ago

Reviewers:
scheglov, Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

One extension manager (to bind them all). TL;DR Moves all plugin registration to AE's extension manager. The rub is that plugin registration wasn't happening right which cropped up in integration testing. Included is a test that verifies that options are getting properly threaded through to the linter. (This test failed when we had two Extension Managers.) R=brianwilkerson@google.com, scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/6bce9b237392df52d6f4cf97df08eec5fd996be1

Patch Set 1 #

Patch Set 2 : Reverted pubspec. #

Patch Set 3 : Unstage pubspec. #

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+73 lines, -4 lines)			Patch
M	pkg/analysis_server/lib/src/server/driver.dart	View		1 chunk	+6 lines, -3 lines	0 comments	Download
M	pkg/analysis_server/pubspec.yaml	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download
A	pkg/analysis_server/test/integration/analysis/lint_test.dart	View		1 chunk	+65 lines, -0 lines	0 comments	Download
M	pkg/analysis_server/test/integration/analysis/test_all.dart	View		2 chunks	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

scheglov

LGTM I guess I will need to update my Angular integration and set all the ...

5 years, 2 months ago (2015-10-13 23:23:34 UTC) #4

pquitslund

5 years, 2 months ago (2015-10-13 23:37:46 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
6bce9b237392df52d6f4cf97df08eec5fd996be1 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages