Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Unified Diff: tools/release/test_scripts.py

Issue 1398033003: [Release] Update merge script to leverage auto-tag bot (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Reviewable version Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« tools/release/merge_to_branch.py ('K') | « tools/release/merge_to_branch.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/release/test_scripts.py
diff --git a/tools/release/test_scripts.py b/tools/release/test_scripts.py
index 3c1f31d494f914b6c2d1f012571c0956fb7342a9..9ff40a66bd658abf3c1cb7cd6cd8b7b9e1518c2b 100644
--- a/tools/release/test_scripts.py
+++ b/tools/release/test_scripts.py
@@ -1157,23 +1157,22 @@ deps = {
return lambda: self.assertEquals(patch,
FileToText(TEST_CONFIG["TEMPORARY_PATCH_FILE"]))
- msg = """Version 3.22.5.1 (cherry-pick)
+ msg = """Merged: Squashed multiple commits.
-Merged ab12345
-Merged ab23456
-Merged ab34567
-Merged ab45678
-Merged ab56789
+Merged: Title4
+Hash: ab12345
-Title4
+Merged: Title2
+Hash: ab23456
-Title2
+Merged: Title3
+Hash: ab34567
-Title3
+Merged: Title1
+Hash: ab45678
-Title1
-
-Revert "Something"
+Merged: Revert \"Something\"
+Hash: ab56789
BUG=123,234,345,456,567,v8:123
LOG=N
@@ -1182,13 +1181,6 @@ LOG=N
def VerifyLand():
commit = FileToText(TEST_CONFIG["COMMITMSG_FILE"])
self.assertEquals(msg, commit)
- version = FileToText(
- os.path.join(TEST_CONFIG["DEFAULT_CWD"], VERSION_FILE))
- self.assertTrue(re.search(r"#define V8_MINOR_VERSION\s+22", version))
- self.assertTrue(re.search(r"#define V8_BUILD_NUMBER\s+5", version))
- self.assertTrue(re.search(r"#define V8_PATCH_LEVEL\s+1", version))
- self.assertTrue(
- re.search(r"#define V8_IS_CANDIDATE_VERSION\s+0", version))
self.Expect([
Cmd("git status -s -uno", ""),
@@ -1197,15 +1189,15 @@ LOG=N
Cmd("git branch", " branch1\n* branch2\n"),
Cmd("git new-branch %s --upstream refs/remotes/origin/candidates" %
TEST_CONFIG["BRANCHNAME"], ""),
- Cmd(("git log --format=%H --grep=\"Port ab12345\" "
+ Cmd(("git log --format=%H --grep=\"^[P,p]ort ab12345\" "
"--reverse origin/master"),
"ab45678\nab23456"),
Cmd("git log -1 --format=%s ab45678", "Title1"),
Cmd("git log -1 --format=%s ab23456", "Title2"),
- Cmd(("git log --format=%H --grep=\"Port ab23456\" "
+ Cmd(("git log --format=%H --grep=\"^[P,p]ort ab23456\" "
"--reverse origin/master"),
""),
- Cmd(("git log --format=%H --grep=\"Port ab34567\" "
+ Cmd(("git log --format=%H --grep=\"^[P,p]ort ab34567\" "
"--reverse origin/master"),
"ab56789"),
Cmd("git log -1 --format=%s ab56789", "Title3"),
@@ -1244,7 +1236,6 @@ LOG=N
TEST_CONFIG["TEMPORARY_PATCH_FILE"]),
"", cb=VerifyPatch("patch5\n")),
Cmd("git apply --index --reject \"%s\"" % extra_patch, ""),
- RL("Y"), # Automatically increment patch level?
Cmd("git commit -aF \"%s\"" % TEST_CONFIG["COMMITMSG_FILE"], ""),
RL("reviewer@chromium.org"), # V8 reviewer.
Cmd("git cl upload --send-mail -r \"reviewer@chromium.org\" "
@@ -1254,18 +1245,6 @@ LOG=N
Cmd("git cl presubmit", "Presubmit successfull\n"),
Cmd("git cl land -f --bypass-hooks", "Closing issue\n",
cb=VerifyLand),
- Cmd("git fetch", ""),
- Cmd("git log -1 --format=%H --grep=\""
- "Version 3.22.5.1 (cherry-pick)"
- "\" refs/remotes/origin/candidates",
- ""),
- Cmd("git fetch", ""),
- Cmd("git log -1 --format=%H --grep=\""
- "Version 3.22.5.1 (cherry-pick)"
- "\" refs/remotes/origin/candidates",
- "hsh_to_tag"),
- Cmd("git tag 3.22.5.1 hsh_to_tag", ""),
- Cmd("git push origin 3.22.5.1", ""),
Cmd("git checkout -f origin/master", ""),
Cmd("git branch -D %s" % TEST_CONFIG["BRANCHNAME"], ""),
])
« tools/release/merge_to_branch.py ('K') | « tools/release/merge_to_branch.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698