Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1368)

Unified Diff: Source/modules/speech/SpeechGrammar.h

Issue 139803012: Move speech module over to Oilpan. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Pull in TraceTrait<RefPtr<T>> template specialization + add trace() over RawPtr<T>s. Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/speech/SpeechGrammar.h
diff --git a/Source/modules/speech/SpeechGrammar.h b/Source/modules/speech/SpeechGrammar.h
index e7bff2a37af6ae6a79bd5771e235c14ec852cf9b..2f3cab5c16a08501ae7d3bb0ca7b3fed6ded96db 100644
--- a/Source/modules/speech/SpeechGrammar.h
+++ b/Source/modules/speech/SpeechGrammar.h
@@ -27,6 +27,7 @@
#define SpeechGrammar_h
#include "bindings/v8/ScriptWrappable.h"
+#include "heap/Handle.h"
#include "platform/weborigin/KURL.h"
#include "wtf/RefCounted.h"
#include "wtf/text/WTFString.h"
@@ -35,10 +36,11 @@ namespace WebCore {
class ExecutionContext;
-class SpeechGrammar : public ScriptWrappable, public RefCounted<SpeechGrammar> {
+class SpeechGrammar : public RefCountedWillBeGarbageCollectedFinalized<SpeechGrammar>, public ScriptWrappable {
+ DECLARE_GC_INFO;
public:
- static PassRefPtr<SpeechGrammar> create(); // FIXME: The spec is not clear on what the constructor should look like.
- static PassRefPtr<SpeechGrammar> create(const KURL& src, double weight);
+ static PassRefPtrWillBeRawPtr<SpeechGrammar> create(); // FIXME: The spec is not clear on what the constructor should look like.
+ static PassRefPtrWillBeRawPtr<SpeechGrammar> create(const KURL& src, double weight);
const KURL& src(ExecutionContext*) const { return m_src; }
const KURL& src() const { return m_src; }
@@ -47,6 +49,8 @@ public:
double weight() const { return m_weight; }
void setWeight(double weight) { m_weight = weight; }
+ void trace(Visitor*) { }
+
private:
SpeechGrammar();
SpeechGrammar(const KURL& src, double weight);

Powered by Google App Engine
This is Rietveld 408576698