Move speech module over to Oilpan.

Source/modules/speech/SpeechRecognition.cpp

Index: Source/modules/speech/SpeechRecognition.cpp
diff --git a/Source/modules/speech/SpeechRecognition.cpp b/Source/modules/speech/SpeechRecognition.cpp
index 364332ee89098792393ccd585a9bcdf32895dd6b..03eef7dbe8ca04d3baaaf3e38af408ec0efbc4ba 100644
--- a/Source/modules/speech/SpeechRecognition.cpp
+++ b/Source/modules/speech/SpeechRecognition.cpp
@@ -37,9 +37,11 @@
 
 namespace WebCore {
 
-PassRefPtr<SpeechRecognition> SpeechRecognition::create(ExecutionContext* context)
+DEFINE_GC_INFO(SpeechRecognition);
+
+PassRefPtrWillBeRawPtr<SpeechRecognition> SpeechRecognition::create(ExecutionContext* context)
 {
-    RefPtr<SpeechRecognition> speechRecognition(adoptRef(new SpeechRecognition(context)));
+    RefPtrWillBeRawPtr<SpeechRecognition> speechRecognition(adoptRefWillBeNoop(new SpeechRecognition(context)));

[zerny-chromium, 2014/02/12 11:45:19]

This needs to be adoptRefCountedWillBeRefCountedGarbageCollected so long as the
GC'ed type is RefCountedGarbageCollected.

[sof, 2014/02/12 16:18:13]

Thanks, done (and for the other types that are based on
RefCountedGarbageCollected.)

     speechRecognition->suspendIfNeeded();
     return speechRecognition.release();
 }
@@ -113,7 +115,9 @@ void SpeechRecognition::didReceiveResults(const Vector<RefPtr<SpeechRecognitionR
     for (size_t i = 0; i < newFinalResults.size(); ++i)
         m_finalResults.append(newFinalResults[i]);
 
-    Vector<RefPtr<SpeechRecognitionResult> > results = m_finalResults;
+    Vector<RefPtr<SpeechRecognitionResult> > results(m_finalResults.size());

[haraken, 2014/02/12 11:12:54]

Can you simply use WillBeHeapVector<RefPtrWillBeMember<>> ? A HeapVector on a
stack is visited by the conservative scanning.

[sof, 2014/02/12 12:00:23]

As long as SpeechRecognitionEvent hasn't been moved over, passing in a
heap-allocated vector would be problematic? Unless we have it use a Persistent.

[sof, 2014/02/12 16:18:13]

I took another pop at this, but the inter-relationships between the types here
is somewhat tight. Until the platform API layer and its WebPrivatePtrs have been
converted, I don't see how this can be done.

To go with that, m_finalResults is now a Vector<>, so the manual copying here
isn't needed.

+    for (size_t i = 0; i < m_finalResults.size(); ++i)
+        results[i] = m_finalResults[i];

[zerny-chromium, 2014/02/12 11:45:19]

We should mark such oilpan introduced deficiencies with a FIXME: oilpan: so we
can find a fix when possible.

[sof, 2014/02/12 16:18:13]

Alright, thanks. The potential FIXME disappears here w/ m_finalResults no longer
be a heap vector.

     for (size_t i = 0; i < currentInterimResults.size(); ++i)
         results.append(currentInterimResults[i]);
 
@@ -189,4 +193,9 @@ SpeechRecognition::~SpeechRecognition()
 {
 }
 
+void SpeechRecognition::trace(Visitor* visitor)
+{
+    visitor->trace(m_grammars);

[haraken, 2014/02/12 11:12:54]

You're missing visitor->trace(m_finalResults).

[zerny-chromium, 2014/02/12 11:45:19]

This needs to trace m_finalResults (if it becomes a heap-allocated vector)

[sof, 2014/02/12 16:18:13]

I missed the reqd tracing of it, sorry. But it is not heap allocated now.

+}
+
 } // namespace WebCore