Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Unified Diff: Source/modules/speech/SpeechGrammarList.cpp

Issue 139803012: Move speech module over to Oilpan. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: More namespace tweaks for clang Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/speech/SpeechGrammarList.cpp
diff --git a/Source/modules/speech/SpeechGrammarList.cpp b/Source/modules/speech/SpeechGrammarList.cpp
index 6dfe69ee483197a8d7472c6ab3988c8f7f10ae27..eee62a46f566433b487ffa9044b066cddfcba141 100644
--- a/Source/modules/speech/SpeechGrammarList.cpp
+++ b/Source/modules/speech/SpeechGrammarList.cpp
@@ -31,9 +31,11 @@
namespace WebCore {
-PassRefPtr<SpeechGrammarList> SpeechGrammarList::create()
+DEFINE_GC_INFO(SpeechGrammarList);
+
+PassRefPtrWillBeRawPtr<SpeechGrammarList> SpeechGrammarList::create()
{
- return adoptRef(new SpeechGrammarList);
+ return adoptRefWillBeNoop(new SpeechGrammarList);
}
SpeechGrammar* SpeechGrammarList::item(unsigned long index) const
@@ -61,4 +63,11 @@ SpeechGrammarList::SpeechGrammarList()
ScriptWrappable::init(this);
}
+void SpeechGrammarList::trace(Visitor* visitor)
+{
+#if ENABLE(OILPAN)
haraken 2014/02/12 05:18:45 Is this #if needed?
sof 2014/02/12 07:48:51 Yes, I couldn't get it to compile without: ../../
haraken 2014/02/12 08:04:50 Shall we add trace() to RefPtr.h? It wouldn't be n
zerny-chromium 2014/02/12 12:13:41 Ah, we need to fix this for tracing elements that
sof 2014/02/12 12:16:55 alright, will try to bring that about.
sof 2014/02/12 16:18:13 Left in the conditional ENABLE(OILPAN) in the trac
+ visitor->trace(m_grammars);
+#endif
+}
+
} // namespace WebCore

Powered by Google App Engine
This is Rietveld 408576698