Move speech module over to Oilpan.

Source/modules/speech/SpeechRecognitionResultList.cpp

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *  * Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  *  * Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 11 matching lines @@
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "config.h"
 
 #include "modules/speech/SpeechRecognitionResultList.h"
 
 namespace WebCore {
 
-PassRefPtr<SpeechRecognitionResultList> SpeechRecognitionResultList::create(const Vector<RefPtr<SpeechRecognitionResult> >& results)
+DEFINE_GC_INFO(SpeechRecognitionResultList);
+
+PassRefPtrWillBeRawPtr<SpeechRecognitionResultList> SpeechRecognitionResultList::create(const Vector<RefPtr<SpeechRecognitionResult> >& results)
 {
-    return adoptRef(new SpeechRecognitionResultList(results));
+    return adoptRefWillBeNoop(new SpeechRecognitionResultList(results));
 }
 
 SpeechRecognitionResult* SpeechRecognitionResultList::item(unsigned long index)
 {
     if (index >= m_results.size())
         return 0;
 
     return m_results[index].get();
 }
 
 SpeechRecognitionResultList::SpeechRecognitionResultList(const Vector<RefPtr<SpeechRecognitionResult> >& results)
+#if !ENABLE(OILPAN)
     : m_results(results)

[Vyacheslav Egorov (Chromium), 2014/02/14 14:01:42]

We could provide a correctly delegating copying constructor to avoid these
changes.

[sof, 2014/02/16 20:29:15]

Yes, the eyesore would disappear then, but I'd be interested to hear suggestions
of how to address the underlying problem here.

That is, has the project worked out how to handle 'Blink platform layer' objects
(I might be using the completely wrong terminology here, sorry, but I refer to
the objects exposed by public/web/ ) that hold references to Oilpan heap
objects? Without exposing the underlying Oilpan types in those interfaces.

[I've been experimenting with a WebPrivateHeapPtr type, which holds a persistent
reference when compiled with Oilpan enabled. It indirectly solves the above.]

[haraken, 2014/02/17 01:21:35]

I think this is the right way to go. You can refer to You can refer to
Source/WebKit/chromium/public/WebRange.h in the experimental branch and see how
to address the WebPrivatePtr issue.

+#endif
 {
     ScriptWrappable::init(this);
+#if ENABLE(OILPAN)
+    m_results.grow(results.size());
+    for (size_t i = 0; i < results.size(); i++)
+        m_results[i] = results[i].get();
+#endif
+}
+
+void SpeechRecognitionResultList::trace(Visitor* visitor)
+{
+    visitor->trace(m_results);
 }
 
 } // namespace WebCore