Move speech module over to Oilpan.

Source/modules/speech/SpeechRecognition.cpp

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *  * Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  *  * Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 19 matching lines @@
 #include "bindings/v8/ExceptionState.h"
 #include "core/dom/Document.h"
 #include "core/dom/ExceptionCode.h"
 #include "core/page/Page.h"
 #include "modules/speech/SpeechRecognitionController.h"
 #include "modules/speech/SpeechRecognitionError.h"
 #include "modules/speech/SpeechRecognitionEvent.h"
 
 namespace WebCore {
 
-PassRefPtr<SpeechRecognition> SpeechRecognition::create(ExecutionContext* context)
+DEFINE_GC_INFO(SpeechRecognition);
+
+PassRefPtrWillBeRawPtr<SpeechRecognition> SpeechRecognition::create(ExecutionContext* context)
 {
-    RefPtr<SpeechRecognition> speechRecognition(adoptRef(new SpeechRecognition(context)));
+    RefPtrWillBeRawPtr<SpeechRecognition> speechRecognition(adoptRefWillBeNoop(new SpeechRecognition(context)));

[zerny-chromium, 2014/02/12 11:45:19]

This needs to be adoptRefCountedWillBeRefCountedGarbageCollected so long as the
GC'ed type is RefCountedGarbageCollected.

[sof, 2014/02/12 16:18:13]

Thanks, done (and for the other types that are based on
RefCountedGarbageCollected.)

     speechRecognition->suspendIfNeeded();
     return speechRecognition.release();
 }
 
 void SpeechRecognition::start(ExceptionState& exceptionState)
 {
     ASSERT(m_controller);
     if (m_started) {
         exceptionState.throwDOMException(InvalidStateError, "recognition has already started.");
         return;
@@ skipping 53 matching lines @@
     dispatchEvent(Event::create(EventTypeNames::audioend));
 }
 
 void SpeechRecognition::didReceiveResults(const Vector<RefPtr<SpeechRecognitionResult> >& newFinalResults, const Vector<RefPtr<SpeechRecognitionResult> >& currentInterimResults)
 {
     unsigned long resultIndex = m_finalResults.size();
 
     for (size_t i = 0; i < newFinalResults.size(); ++i)
         m_finalResults.append(newFinalResults[i]);
 
-    Vector<RefPtr<SpeechRecognitionResult> > results = m_finalResults;
+    Vector<RefPtr<SpeechRecognitionResult> > results(m_finalResults.size());

[haraken, 2014/02/12 11:12:54]

Can you simply use WillBeHeapVector<RefPtrWillBeMember<>> ? A HeapVector on a
stack is visited by the conservative scanning.

[sof, 2014/02/12 12:00:23]

As long as SpeechRecognitionEvent hasn't been moved over, passing in a
heap-allocated vector would be problematic? Unless we have it use a Persistent.

[sof, 2014/02/12 16:18:13]

I took another pop at this, but the inter-relationships between the types here
is somewhat tight. Until the platform API layer and its WebPrivatePtrs have been
converted, I don't see how this can be done.

To go with that, m_finalResults is now a Vector<>, so the manual copying here
isn't needed.

+    for (size_t i = 0; i < m_finalResults.size(); ++i)
+        results[i] = m_finalResults[i];

[zerny-chromium, 2014/02/12 11:45:19]

We should mark such oilpan introduced deficiencies with a FIXME: oilpan: so we
can find a fix when possible.

[sof, 2014/02/12 16:18:13]

Alright, thanks. The potential FIXME disappears here w/ m_finalResults no longer
be a heap vector.

     for (size_t i = 0; i < currentInterimResults.size(); ++i)
         results.append(currentInterimResults[i]);
 
     dispatchEvent(SpeechRecognitionEvent::createResult(resultIndex, results));
 }
 
 void SpeechRecognition::didReceiveNoMatch(PassRefPtr<SpeechRecognitionResult> result)
 {
     dispatchEvent(SpeechRecognitionEvent::createNoMatch(result));
 }
@@ skipping 55 matching lines @@
     m_controller = SpeechRecognitionController::from(page);
     ASSERT(m_controller);
 
     // FIXME: Need to hook up with Page to get notified when the visibility changes.
 }
 
 SpeechRecognition::~SpeechRecognition()
 {
 }
 
+void SpeechRecognition::trace(Visitor* visitor)
+{
+    visitor->trace(m_grammars);

[haraken, 2014/02/12 11:12:54]

You're missing visitor->trace(m_finalResults).

[zerny-chromium, 2014/02/12 11:45:19]

This needs to trace m_finalResults (if it becomes a heap-allocated vector)

[sof, 2014/02/12 16:18:13]

I missed the reqd tracing of it, sorry. But it is not heap allocated now.

+}
+
 } // namespace WebCore