Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 139803011: tls_edit added as dependency to nacl_irt (Closed)

Created:
6 years, 10 months ago by David Yen
Modified:
6 years, 10 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

tls_edit added as a dependency to nacl_irt Now that build_nexe.py is in charge of applying tls_edit, nacl_irt needs to depend on tls_edit#host. BUG= https://code.google.com/p/nativeclient/issues/detail?id=3126 TEST= trybots Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250291

Patch Set 1 #

Patch Set 2 : Added back in tls_edit rules, we should only add tls_edit dependency in this CL #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M ppapi/native_client/native_client.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
David Yen
I removed the rules to apply tls_edit to the nacl_irt on the chromium side. These ...
6 years, 10 months ago (2014-02-10 21:21:26 UTC) #1
noelallen1
LGTM, but please retry with -rHEAD, looks like a patch issue.
6 years, 10 months ago (2014-02-10 21:40:11 UTC) #2
David Yen
The CQ bit was checked by dyen@chromium.org
6 years, 10 months ago (2014-02-10 22:32:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dyen@chromium.org/139803011/60001
6 years, 10 months ago (2014-02-10 22:59:22 UTC) #4
Mark Seaborn
Could we declare the dependency in untrusted.gypi, so that the Chromium side doesn't have to ...
6 years, 10 months ago (2014-02-10 23:10:28 UTC) #5
David Yen
On 2014/02/10 23:10:28, Mark Seaborn wrote: > Could we declare the dependency in untrusted.gypi, so ...
6 years, 10 months ago (2014-02-10 23:14:32 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-10 23:33:32 UTC) #7
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=49362
6 years, 10 months ago (2014-02-10 23:33:32 UTC) #8
David Yen
Added Noel's google account, looks like the google account is the one in the OWNERS ...
6 years, 10 months ago (2014-02-10 23:38:36 UTC) #9
noelallen_use_chromium
lgtm
6 years, 10 months ago (2014-02-11 00:02:44 UTC) #10
David Yen
The CQ bit was checked by dyen@chromium.org
6 years, 10 months ago (2014-02-11 00:04:40 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dyen@chromium.org/139803011/60001
6 years, 10 months ago (2014-02-11 00:05:46 UTC) #12
commit-bot: I haz the power
Change committed as 250291
6 years, 10 months ago (2014-02-11 02:32:00 UTC) #13
Mark Seaborn
6 years, 10 months ago (2014-02-12 21:04:37 UTC) #14
Message was sent while issue was closed.
For the record, this should have:
BUG=https://code.google.com/p/nativeclient/issues/detail?id=3127

Powered by Google App Engine
This is Rietveld 408576698