Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Unified Diff: chromeos/ime/input_method_manager.h

Issue 139803010: Support comma separated hardware keyboard layout. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressing comments Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/ime/input_method_manager.h
diff --git a/chromeos/ime/input_method_manager.h b/chromeos/ime/input_method_manager.h
index c86a07eb8c446cf2e816caa8370e53c55e0bbdd5..453b26cdcdba918ae723dce8c5dbf4e107ad861d 100644
--- a/chromeos/ime/input_method_manager.h
+++ b/chromeos/ime/input_method_manager.h
@@ -116,14 +116,15 @@ class CHROMEOS_EXPORT InputMethodManager {
// Enables "login" keyboard layouts (e.g. US Qwerty, US Dvorak, French
// Azerty) that are necessary for the |language_code| and then switches to
- // |initial_layout| if the string is not empty. For example, if
+ // |initial_layouts| if the given list is not empty. For example, if
// |language_code| is "en-US", US Qwerty, US International, US Extended, US
// Dvorak, and US Colemak layouts would be enabled. Likewise, for Germany
// locale, US Qwerty which corresponds to the hardware keyboard layout and
// several keyboard layouts for Germany would be enabled.
- // Only layouts suitable for login screen are enabled.
- virtual void EnableLoginLayouts(const std::string& language_code,
- const std::string& initial_layout) = 0;
+ // Only layouts suitable for login screen are enabled.
+ virtual void EnableLoginLayouts(
+ const std::string& language_code,
+ const std::vector<std::string>& initial_layouts) = 0;
// Activates the input method property specified by the |key|.
virtual void ActivateInputMethodProperty(const std::string& key) = 0;
@@ -153,8 +154,8 @@ class CHROMEOS_EXPORT InputMethodManager {
// Sets the list of extension IME ids which should be enabled.
virtual void SetEnabledExtensionImes(std::vector<std::string>* ids) = 0;
- // Sets current input method to default (first owners, then hardware).
- virtual void SetInputMethodDefault() = 0;
+ // Sets current input method to login default (first owners, then hardware).
+ virtual void SetInputMethodLoginDefault() = 0;
// Gets the descriptor of the input method which is currently selected.
virtual InputMethodDescriptor GetCurrentInputMethod() const = 0;

Powered by Google App Engine
This is Rietveld 408576698