Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3052)

Unified Diff: chrome/browser/chromeos/input_method/input_method_delegate_impl.cc

Issue 139803010: Support comma separated hardware keyboard layout. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressing comments Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/input_method/input_method_delegate_impl.cc
diff --git a/chrome/browser/chromeos/input_method/input_method_delegate_impl.cc b/chrome/browser/chromeos/input_method/input_method_delegate_impl.cc
index ddfbe69dea6b4f17f41d8981ef514b9847453d28..01f63e92de88e6d03f35f4c2e79aa0666472a08d 100644
--- a/chrome/browser/chromeos/input_method/input_method_delegate_impl.cc
+++ b/chrome/browser/chromeos/input_method/input_method_delegate_impl.cc
@@ -6,6 +6,7 @@
#include "base/logging.h"
#include "base/prefs/pref_service.h"
+#include "base/strings/string_util.h"
#include "chrome/browser/browser_process.h"
#include "chrome/common/pref_names.h"
#include "ui/base/l10n/l10n_util.h"
@@ -13,17 +14,21 @@
namespace chromeos {
namespace input_method {
-InputMethodDelegateImpl::InputMethodDelegateImpl() {}
-
-std::string InputMethodDelegateImpl::GetHardwareKeyboardLayout() const {
- if (g_browser_process) {
- PrefService* local_state = g_browser_process->local_state();
- if (local_state)
- return local_state->GetString(prefs::kHardwareKeyboardLayout);
- }
- // This shouldn't happen but just in case.
- DVLOG(1) << "Local state is not yet ready.";
- return std::string();
+InputMethodDelegateImpl::InputMethodDelegateImpl() {
+}
+
+InputMethodDelegateImpl::~InputMethodDelegateImpl() {
+}
+
+std::string InputMethodDelegateImpl::GetHardwareKeyboardLayouts() const {
+ if (!g_browser_process)
+ return "";
+
+ PrefService* local_state = g_browser_process->local_state();
+ if (!local_state)
+ return "";
+
+ return local_state->GetString(prefs::kHardwareKeyboardLayout);
}
base::string16 InputMethodDelegateImpl::GetLocalizedString(
@@ -40,5 +45,10 @@ base::string16 InputMethodDelegateImpl::GetDisplayLanguageName(
true);
}
+void InputMethodDelegateImpl::SetHardwareKeyboardLayoutForTesting(
+ const std::string& layout) {
+ NOTREACHED();
Hiro Komatsu 2014/02/14 07:16:51 Please add a comment why it's not reachable.
Seigo Nonaka 2014/02/14 08:13:22 Done.
+}
+
} // namespace input_method
} // namespace chromeos

Powered by Google App Engine
This is Rietveld 408576698