Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1398023002: Give the SupportedMachineOperatorFlags to GraphAndBuilders to allow the use of optional operators i… (Closed)

Created:
5 years, 2 months ago by ahaas
Modified:
5 years, 2 months ago
Reviewers:
ahaas1, titzer, Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Give the SupportedMachineOperatorFlags to GraphAndBuilders to allow the use of optional operators in tests. BUG= Committed: https://crrev.com/f7e9094fe27de8d4ae5c2d0dc81fcf67f9b5c8c1 Cr-Commit-Position: refs/heads/master@{#31203}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M test/cctest/compiler/graph-builder-tester.h View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 16 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1398023002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1398023002/1
5 years, 2 months ago (2015-10-09 08:19:11 UTC) #3
commit-bot: I haz the power
Dry run: No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even ...
5 years, 2 months ago (2015-10-09 08:19:13 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1398023002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1398023002/1
5 years, 2 months ago (2015-10-09 08:27:51 UTC) #7
commit-bot: I haz the power
Dry run: No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even ...
5 years, 2 months ago (2015-10-09 08:27:53 UTC) #9
ahaas1
5 years, 2 months ago (2015-10-09 08:30:15 UTC) #11
Jarin
lgtm
5 years, 2 months ago (2015-10-09 08:43:03 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1398023002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1398023002/1
5 years, 2 months ago (2015-10-11 19:36:42 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-11 19:59:29 UTC) #15
commit-bot: I haz the power
5 years, 2 months ago (2015-10-11 19:59:49 UTC) #16
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/f7e9094fe27de8d4ae5c2d0dc81fcf67f9b5c8c1
Cr-Commit-Position: refs/heads/master@{#31203}

Powered by Google App Engine
This is Rietveld 408576698