LayoutTests/fast/images/webp-animated-large.html - Issue 13980003: Add animation support for WebP images

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/images/webp-animated-large.html

Issue 13980003: Add animation support for WebP images (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/fast/images/resources/webp-animated-large.webp ('k') | LayoutTests/fast/images/webp-animated-large-expected.txt » ('j') | Source/core/platform/image-decoders/webp/WEBPImageDecoder.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <script>

	2 if (window.testRunner)

	3 window.testRunner.dumpAsText();

	4 </script>

	5 This test passes if no errors occur while decoding this large animation.<br>

	6 <img src="resources/webp-animated-large.webp">
	Noel Gordon 2013/05/01 19:11:41 As suggested, crib your layout test from fast/imag As suggested, crib your layout test from fast/images/webp-image-decoding.html to appease our ASAN/TSAN bots. urvang (Google) 2013/05/01 22:25:16 Oh these run under ASAN/TSAN, good. However, just Show quoted text On 2013/05/01 19:11:41, Noel Gordon (Google) wrote: > As suggested, crib your layout test from fast/images/webp-image-decoding.html to > appease our ASAN/TSAN bots. Oh these run under ASAN/TSAN, good. However, just realized that these tests won't work as "RuntimeEnabledFeatures::animatedWebPEnabled()" is false by default. (Not sure how it was working so far). Question: Is there a way to enable this flag for layout tests (similar to the way it is done in unit tests)? Otherwise, I'm just putting test expectation to be 'failure' for now. Noel Gordon 2013/05/02 18:00:27 http://build.chromium.org/p/chromium.webkit/builde Show quoted text On 2013/05/01 22:25:16, urvang wrote: > Oh these run under ASAN/TSAN, good. http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20ASAN for example. Show quoted text > However, just realized that these tests won't work as > "RuntimeEnabledFeatures::animatedWebPEnabled()" is false by default. (Not sure > how it was working so far). > > Question: Is there a way to enable this flag for layout tests (similar to the > way it is done in unit tests)? Yes, and the enable will soon be auto-generated according to Eric. Failing that, you modify InternalSettings to allow a layout test to set a runtime flag. For example, % grep CSSVariables Source/core/testing/InternalSettings.* and see LayoutTests/fast/css/variables/invalid-font-reference.html Show quoted text > Otherwise, I'm just putting test expectation to be 'failure' for now. Seems fine for now. Expect news from Eric.
OLD	NEW