LayoutTests/fast/images/webp-animated-large.html - Issue 13980003: Add animation support for WebP images

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/images/webp-animated-large.html

Issue 13980003: Add animation support for WebP images (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« LayoutTests/fast/images/invalid-animated-webp.html ('K') | « LayoutTests/fast/images/resources/webp-animated-large.webp ('k') | LayoutTests/fast/images/webp-animated-large-expected.txt » ('j') | Source/WebKit/chromium/tests/WEBPImageDecoderTest.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <script>

	2 if (window.testRunner)

	3 window.testRunner.dumpAsText();

	4 </script>

	5 This test passes if no errors occur while decoding this large animation.<br>
	Noel Gordon 2013/04/29 18:41:57 How does this test work? If there were decoding e How does this test work? If there were decoding errors, I don't see how it detects those errors. urvang (Google) 2013/04/30 13:14:15 I had added this test hoping that Layout tests may Show quoted text On 2013/04/29 18:41:57, Noel Gordon (Google) wrote: > How does this test work? If there were decoding errors, I don't see how it > detects those errors. I had added this test hoping that Layout tests may be designed to catch memory errors (for example, clearFrameBuffer() would be called only for large animations), but perhaps not. Now that I've added WEBPImageDecoderTest.cpp, which should be much more comprehensive, we could remove this if you suggest so. And I could add this image to be tested there. Noel Gordon 2013/05/01 17:55:28 The unit test is fine, but we also want a layout t Show quoted text On 2013/04/30 13:14:15, urvang wrote: > On 2013/04/29 18:41:57, Noel Gordon (Google) wrote: > > How does this test work? If there were decoding errors, I don't see how it > > detects those errors. > > I had added this test hoping that Layout tests may be designed to catch memory > errors (for example, clearFrameBuffer() would be called only for large > animations), but perhaps not. > > Now that I've added WEBPImageDecoderTest.cpp, which should be much more > comprehensive, we could remove this if you suggest so. And I could add this > image to be tested there. The unit test is fine, but we also want a layout test since they get tested with the ASAN and TSAN bots that check for memory leaks and threading issues, respectively. Suggest you look at fast/images/webp-image-decoding.html and crib something similar for animated webp images. Find three images to test with, for example, the ones you added to fast/image/resources =)
	6 <img src="resources/webp-animated-large.webp">

OLD	NEW