bluetooth: Refactor repeated code used to find a Bluetooth object from its ID.

content/browser/bluetooth/bluetooth_metrics.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/bluetooth/bluetooth_metrics.h"
 
 #include <map>
 #include <set>
 #include "base/hash.h"
 #include "base/metrics/histogram_macros.h"
@@ skipping 85 matching lines @@
 }
 
 // connectGATT
 
 void RecordConnectGATTOutcome(UMAConnectGATTOutcome outcome) {
   UMA_HISTOGRAM_ENUMERATION("Bluetooth.Web.ConnectGATT.Outcome",
                             static_cast<int>(outcome),
                             static_cast<int>(UMAConnectGATTOutcome::COUNT));
 }
 
+void RecordConnectGATTOutcome(CacheQueryOutcome outcome) {
+  DCHECK(outcome == CacheQueryOutcome::NO_DEVICE);
+  RecordConnectGATTOutcome(UMAConnectGATTOutcome::NO_DEVICE);
+}
+
 void RecordConnectGATTTimeSuccess(const base::TimeDelta& duration) {
   UMA_HISTOGRAM_MEDIUM_TIMES("Bluetooth.Web.ConnectGATT.TimeSuccess", duration);
 }
 
 void RecordConnectGATTTimeFailed(const base::TimeDelta& duration) {
   UMA_HISTOGRAM_MEDIUM_TIMES("Bluetooth.Web.ConnectGATT.TimeFailed", duration);
 }
 
 // getPrimaryService
 
 void RecordGetPrimaryServiceService(const BluetoothUUID& service) {
   // TODO(ortuno): Use a macro to histogram strings.
   // http://crbug.com/520284
   UMA_HISTOGRAM_SPARSE_SLOWLY("Bluetooth.Web.GetPrimaryService.Services",
                               HashUUID(service.canonical_value()));
 }
 
 void RecordGetPrimaryServiceOutcome(UMAGetPrimaryServiceOutcome outcome) {
   UMA_HISTOGRAM_ENUMERATION(
       "Bluetooth.Web.GetPrimaryService.Outcome", static_cast<int>(outcome),
       static_cast<int>(UMAGetPrimaryServiceOutcome::COUNT));
 }
 
+void RecordGetPrimaryServiceOutcome(CacheQueryOutcome outcome) {
+  DCHECK(outcome == CacheQueryOutcome::NO_DEVICE);
+  RecordGetPrimaryServiceOutcome(UMAGetPrimaryServiceOutcome::NO_DEVICE);
+}
+
 // getCharacteristic
 
 void RecordGetCharacteristicOutcome(UMAGetCharacteristicOutcome outcome) {
   UMA_HISTOGRAM_ENUMERATION(
       "Bluetooth.Web.GetCharacteristic.Outcome", static_cast<int>(outcome),
       static_cast<int>(UMAGetCharacteristicOutcome::COUNT));
 }
 
+void RecordGetCharacteristicOutcome(CacheQueryOutcome outcome) {
+  switch (outcome) {
+    case CacheQueryOutcome::SUCCESS:
+    case CacheQueryOutcome::BAD_RENDERER:
+      NOTREACHED() << "No need to record a success or renderer crash";
+      return;
+    case CacheQueryOutcome::NO_DEVICE:
+      RecordGetCharacteristicOutcome(UMAGetCharacteristicOutcome::NO_DEVICE);
+      return;
+    case CacheQueryOutcome::NO_SERVICE:
+      RecordGetCharacteristicOutcome(UMAGetCharacteristicOutcome::NO_SERVICE);
+      return;
+    case CacheQueryOutcome::NO_CHARACTERISTIC:
+      NOTREACHED();
+      return;
+  }
+}
+
 void RecordGetCharacteristicCharacteristic(const std::string& characteristic) {
   UMA_HISTOGRAM_SPARSE_SLOWLY("Bluetooth.Web.GetCharacteristic.Characteristic",
                               HashUUID(characteristic));
 }
 
 // GATT Operations
 
 void RecordGATTOperationOutcome(UMAGATTOperation operation,
                                 UMAGATTOperationOutcome outcome) {
   switch (operation) {
     case UMAGATTOperation::CHARACTERISTIC_READ:
       RecordCharacteristicReadValueOutcome(outcome);
       return;
     case UMAGATTOperation::CHARACTERISTIC_WRITE:
       RecordCharacteristicWriteValueOutcome(outcome);
       return;
     case UMAGATTOperation::START_NOTIFICATIONS:
       RecordStartNotificationsOutcome(outcome);
       return;
     case UMAGATTOperation::COUNT:
       NOTREACHED();
       return;
   }
   NOTREACHED();
 }
 
+static UMAGATTOperationOutcome TranslateCacheQueryOutcomeToGATTOperationOutcome(
+    CacheQueryOutcome outcome) {
+  switch (outcome) {
+    case CacheQueryOutcome::SUCCESS:
+    case CacheQueryOutcome::BAD_RENDERER:
+      NOTREACHED() << "No need to record success or renderer crash";
+      return UMAGATTOperationOutcome::NOT_SUPPORTED;
+    case CacheQueryOutcome::NO_DEVICE:
+      return UMAGATTOperationOutcome::NO_DEVICE;
+    case CacheQueryOutcome::NO_SERVICE:
+      return UMAGATTOperationOutcome::NO_SERVICE;
+    case CacheQueryOutcome::NO_CHARACTERISTIC:
+      return UMAGATTOperationOutcome::NO_CHARACTERISTIC;
+  }
+  NOTREACHED() << "No need to record success or renderer crash";
+  return UMAGATTOperationOutcome::NOT_SUPPORTED;
+}
+
 // Characteristic.readValue
 
 // static
 void RecordCharacteristicReadValueOutcome(UMAGATTOperationOutcome outcome) {
   UMA_HISTOGRAM_ENUMERATION("Bluetooth.Web.Characteristic.ReadValue.Outcome",
                             static_cast<int>(outcome),
                             static_cast<int>(UMAGATTOperationOutcome::COUNT));
 }
 
+void RecordCharacteristicReadValueOutcome(CacheQueryOutcome outcome) {
+  RecordCharacteristicReadValueOutcome(
+      TranslateCacheQueryOutcomeToGATTOperationOutcome(outcome));
+}
+
 // Characteristic.writeValue
 
 void RecordCharacteristicWriteValueOutcome(UMAGATTOperationOutcome outcome) {
   UMA_HISTOGRAM_ENUMERATION("Bluetooth.Web.Characteristic.WriteValue.Outcome",
                             static_cast<int>(outcome),
                             static_cast<int>(UMAGATTOperationOutcome::COUNT));
 }
 
+void RecordCharacteristicWriteValueOutcome(CacheQueryOutcome outcome) {
+  RecordCharacteristicWriteValueOutcome(
+      TranslateCacheQueryOutcomeToGATTOperationOutcome(outcome));
+}
+
 // Characteristic.startNotifications
 void RecordStartNotificationsOutcome(UMAGATTOperationOutcome outcome) {
   UMA_HISTOGRAM_ENUMERATION(
       "Bluetooth.Web.Characteristic.StartNotifications.Outcome",
       static_cast<int>(outcome),
       static_cast<int>(UMAGATTOperationOutcome::COUNT));
 }
 
+void RecordStartNotificationsOutcome(CacheQueryOutcome outcome) {
+  RecordStartNotificationsOutcome(
+      TranslateCacheQueryOutcomeToGATTOperationOutcome(outcome));
+}
+
 }  // namespace content