Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1280)

Unified Diff: ppapi/BUILD.gn

Issue 1397953002: GN: Fix NaCl IRT build options (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review nit Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/toolchain/nacl_toolchain.gni ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/BUILD.gn
diff --git a/ppapi/BUILD.gn b/ppapi/BUILD.gn
index 6023bbf660ec6d7c511324efd87328bb67aea929..fa0d2f1810e60f60ef42757816a5c3211a348410 100644
--- a/ppapi/BUILD.gn
+++ b/ppapi/BUILD.gn
@@ -264,17 +264,19 @@ if (enable_nacl) {
# The CPU names used in tests/ppapi_nacl_tests_newlib.nmf
# are the ones used in GYP (x32 for x86).
- if (target_cpu == "x86") {
- nmf_cpu = "x32"
- } else if (current_cpu != "pnacl") {
- nmf_cpu = target_cpu
- }
- if (is_nacl_glibc) {
- suffix = "glibc_${nmf_cpu}"
- } else if (current_cpu == "pnacl") {
+ if (current_cpu == "pnacl") {
suffix = "pnacl"
} else {
- suffix = "newlib_${nmf_cpu}"
+ if (target_cpu == "x86") {
+ nmf_cpu = "x32"
+ } else if (current_cpu != "pnacl") {
+ nmf_cpu = target_cpu
+ }
+ if (is_nacl_glibc) {
+ suffix = "glibc_${nmf_cpu}"
+ } else {
+ suffix = "newlib_${nmf_cpu}"
+ }
}
outputs = [
"${root_build_dir}/{{source_name_part}}_${suffix}.nexe",
« no previous file with comments | « build/toolchain/nacl_toolchain.gni ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698