Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1133)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: build/toolchain/nacl/BUILD.gn

Issue 1397953002: GN: Fix NaCl IRT build options (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review nit Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/toolchain/gcc_toolchain.gni ('k') | build/toolchain/nacl_toolchain.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/toolchain/nacl/BUILD.gn
diff --git a/build/toolchain/nacl/BUILD.gn b/build/toolchain/nacl/BUILD.gn
index 6345cbc56b87388dba79d75cc4ccb5223e921f09..5329f188a418e44498d3710474d62072c0768949 100644
--- a/build/toolchain/nacl/BUILD.gn
+++ b/build/toolchain/nacl/BUILD.gn
@@ -121,6 +121,10 @@ template("nacl_irt_toolchain") {
ar = toolprefix + "ar"
readelf = toolprefix + "readelf"
+ # Always build the IRT with full debugging symbols, regardless of
+ # how Chromium itself is being built (or other NaCl executables).
+ symbol_level = 2
+
# Some IRT implementations (notably, Chromium's) contain C++ code,
# so we need to link w/ the C++ linker.
ld = "${python_path} ${link_irt} --tls-edit=${tls_edit} --link-cmd=${cxx} --readelf-cmd=${readelf}"
« no previous file with comments | « build/toolchain/gcc_toolchain.gni ('k') | build/toolchain/nacl_toolchain.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698