src/IceInstARM32.cpp - Issue 1397933002: Start incorporating the ARM integrated assembler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceInstARM32.cpp

Issue 1397933002: Start incorporating the ARM integrated assembler. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Fix nit and add URL. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceInstARM32.cpp

diff --git a/src/IceInstARM32.cpp b/src/IceInstARM32.cpp

index b07b28388b7065a4687370dee4a7937c3dc420fd..b45d2f1ea28872708913803fb94d37e8f1a6f232 100644

--- a/src/IceInstARM32.cpp

+++ b/src/IceInstARM32.cpp

@@ -969,8 +969,8 @@ void InstARM32Ret::emit(const Cfg *Func) const {

}

void InstARM32Ret::emitIAS(const Cfg *Func) const {

- (void)Func;

- llvm_unreachable("Not yet implemented");

+ ARM32::AssemblerARM32 *Asm = Func->getAssembler<ARM32::AssemblerARM32>();

+ Asm->bx(RegARM32::Encoded_Reg_lr);

}

void InstARM32Ret::dump(const Cfg *Func) const {

« no previous file with comments | « src/IceGlobalContext.cpp ('k') | src/IceTargetLowering.h » ('j') | no next file with comments »