src/IceAssemblerX8632.h - Issue 1397933002: Start incorporating the ARM integrated assembler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceAssemblerX8632.h

Issue 1397933002: Start incorporating the ARM integrated assembler. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Fix nit and add URL. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceAssemblerX8632.h

diff --git a/src/IceAssemblerX8632.h b/src/IceAssemblerX8632.h

index fb9eedf9a81e0d5255d508cb5f7fead37c4dc0a6..3672ecde843844faea5b17de8ee90a6d97fd06b3 100644

--- a/src/IceAssemblerX8632.h

+++ b/src/IceAssemblerX8632.h

@@ -45,8 +45,8 @@ class AssemblerX8632 : public X86Internal::AssemblerX86Base<TargetX8632> {

AssemblerX8632 &operator=(const AssemblerX8632 &) = delete;

public:

- explicit AssemblerX8632(bool use_far_branches = false)

- : X86Internal::AssemblerX86Base<TargetX8632>(Asm_X8632,

+ explicit AssemblerX8632(GlobalContext *Ctx, bool use_far_branches = false)

+ : X86Internal::AssemblerX86Base<TargetX8632>(Asm_X8632, Ctx,

use_far_branches) {}

~AssemblerX8632() override = default;

« no previous file with comments | « src/IceAssemblerMIPS32.h ('k') | src/IceAssemblerX8664.h » ('j') | no next file with comments »