Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(536)

Unified Diff: chrome/browser/sync/glue/local_device_info_provider_unittest.cc

Issue 1397913002: [Sync] Componentize local_device_info_provider_impl and test (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix android Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/glue/local_device_info_provider_unittest.cc
diff --git a/chrome/browser/sync/glue/local_device_info_provider_unittest.cc b/chrome/browser/sync/glue/local_device_info_provider_unittest.cc
deleted file mode 100644
index 9176c3070e1b2ce703e64fa19fa2a9f6979f1da3..0000000000000000000000000000000000000000
--- a/chrome/browser/sync/glue/local_device_info_provider_unittest.cc
+++ /dev/null
@@ -1,93 +0,0 @@
-// Copyright 2014 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "base/bind.h"
-#include "base/message_loop/message_loop.h"
-#include "base/run_loop.h"
-#include "chrome/browser/sync/glue/local_device_info_provider_impl.h"
-#include "sync/util/get_session_name.h"
-#include "testing/gtest/include/gtest/gtest.h"
-
-using sync_driver::DeviceInfo;
-using sync_driver::LocalDeviceInfoProvider;
-
-namespace browser_sync {
-
-const char kLocalDeviceGuid[] = "foo";
-const char kSigninScopedDeviceId[] = "device_id";
-
-class LocalDeviceInfoProviderTest : public testing::Test {
- public:
- LocalDeviceInfoProviderTest()
- : called_back_(false) {}
- ~LocalDeviceInfoProviderTest() override {}
-
- void SetUp() override { provider_.reset(new LocalDeviceInfoProviderImpl()); }
-
- void TearDown() override {
- provider_.reset();
- called_back_ = false;
- }
-
- protected:
- void InitializeProvider() {
- // Start initialization.
- provider_->Initialize(kLocalDeviceGuid, kSigninScopedDeviceId);
-
- // Subscribe to the notification and wait until the callback
- // is called. The callback will quit the loop.
- base::RunLoop run_loop;
- scoped_ptr<LocalDeviceInfoProvider::Subscription> subscription(
- provider_->RegisterOnInitializedCallback(
- base::Bind(&LocalDeviceInfoProviderTest::QuitLoopOnInitialized,
- base::Unretained(this), &run_loop)));
- run_loop.Run();
- }
-
- void QuitLoopOnInitialized(base::RunLoop* loop) {
- called_back_ = true;
- loop->Quit();
- }
-
- scoped_ptr<LocalDeviceInfoProviderImpl> provider_;
-
- bool called_back_;
-
- private:
- base::MessageLoop message_loop_;
-};
-
-TEST_F(LocalDeviceInfoProviderTest, OnInitializedCallback) {
- ASSERT_FALSE(called_back_);
-
- InitializeProvider();
- EXPECT_TRUE(called_back_);
-}
-
-TEST_F(LocalDeviceInfoProviderTest, GetLocalDeviceInfo) {
- ASSERT_EQ(NULL, provider_->GetLocalDeviceInfo());
-
- InitializeProvider();
-
- const DeviceInfo* local_device_info = provider_->GetLocalDeviceInfo();
- EXPECT_TRUE(local_device_info);
- EXPECT_EQ(std::string(kLocalDeviceGuid), local_device_info->guid());
- EXPECT_EQ(std::string(kSigninScopedDeviceId),
- local_device_info->signin_scoped_device_id());
- EXPECT_EQ(syncer::GetSessionNameSynchronouslyForTesting(),
- local_device_info->client_name());
-
- EXPECT_EQ(provider_->GetSyncUserAgent(),
- local_device_info->sync_user_agent());
-}
-
-TEST_F(LocalDeviceInfoProviderTest, GetLocalSyncCacheGUID) {
- ASSERT_EQ(std::string(), provider_->GetLocalSyncCacheGUID());
-
- InitializeProvider();
-
- EXPECT_EQ(std::string(kLocalDeviceGuid), provider_->GetLocalSyncCacheGUID());
-}
-
-} // namespace browser_sync
« no previous file with comments | « chrome/browser/sync/glue/local_device_info_provider_impl.cc ('k') | chrome/browser/sync/glue/sync_backend_host_core.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698