Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Side by Side Diff: components/sync_driver/local_device_info_provider_unittest.cc

Issue 1397913002: [Sync] Componentize local_device_info_provider_impl and test (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix android Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/sync_driver/local_device_info_provider_mock.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/bind.h" 5 #include "base/bind.h"
6 #include "base/message_loop/message_loop.h" 6 #include "base/message_loop/message_loop.h"
7 #include "base/run_loop.h" 7 #include "base/run_loop.h"
8 #include "chrome/browser/sync/glue/local_device_info_provider_impl.h" 8 #include "components/sync_driver/local_device_info_provider_impl.h"
9 #include "components/version_info/version_info.h"
9 #include "sync/util/get_session_name.h" 10 #include "sync/util/get_session_name.h"
10 #include "testing/gtest/include/gtest/gtest.h" 11 #include "testing/gtest/include/gtest/gtest.h"
11 12
12 using sync_driver::DeviceInfo; 13 using sync_driver::DeviceInfo;
13 using sync_driver::LocalDeviceInfoProvider; 14 using sync_driver::LocalDeviceInfoProvider;
14 15
15 namespace browser_sync { 16 namespace browser_sync {
16 17
17 const char kLocalDeviceGuid[] = "foo"; 18 const char kLocalDeviceGuid[] = "foo";
18 const char kSigninScopedDeviceId[] = "device_id"; 19 const char kSigninScopedDeviceId[] = "device_id";
19 20
20 class LocalDeviceInfoProviderTest : public testing::Test { 21 class SyncLocalDeviceInfoProviderTest : public testing::Test {
21 public: 22 public:
22 LocalDeviceInfoProviderTest() 23 SyncLocalDeviceInfoProviderTest() : called_back_(false) {}
23 : called_back_(false) {} 24 ~SyncLocalDeviceInfoProviderTest() override {}
24 ~LocalDeviceInfoProviderTest() override {}
25 25
26 void SetUp() override { provider_.reset(new LocalDeviceInfoProviderImpl()); } 26 void SetUp() override {
27 provider_.reset(new LocalDeviceInfoProviderImpl(
28 version_info::Channel::UNKNOWN,
29 version_info::GetVersionStringWithModifier("UNKNOWN"), false));
30 }
27 31
28 void TearDown() override { 32 void TearDown() override {
29 provider_.reset(); 33 provider_.reset();
30 called_back_ = false; 34 called_back_ = false;
31 } 35 }
32 36
33 protected: 37 protected:
34 void InitializeProvider() { 38 void InitializeProvider() {
35 // Start initialization. 39 // Start initialization.
36 provider_->Initialize(kLocalDeviceGuid, kSigninScopedDeviceId); 40 provider_->Initialize(kLocalDeviceGuid,
41 kSigninScopedDeviceId,
42 message_loop_.task_runner());
37 43
38 // Subscribe to the notification and wait until the callback 44 // Subscribe to the notification and wait until the callback
39 // is called. The callback will quit the loop. 45 // is called. The callback will quit the loop.
40 base::RunLoop run_loop; 46 base::RunLoop run_loop;
41 scoped_ptr<LocalDeviceInfoProvider::Subscription> subscription( 47 scoped_ptr<LocalDeviceInfoProvider::Subscription> subscription(
42 provider_->RegisterOnInitializedCallback( 48 provider_->RegisterOnInitializedCallback(
43 base::Bind(&LocalDeviceInfoProviderTest::QuitLoopOnInitialized, 49 base::Bind(&SyncLocalDeviceInfoProviderTest::QuitLoopOnInitialized,
44 base::Unretained(this), &run_loop))); 50 base::Unretained(this), &run_loop)));
45 run_loop.Run(); 51 run_loop.Run();
46 } 52 }
47 53
48 void QuitLoopOnInitialized(base::RunLoop* loop) { 54 void QuitLoopOnInitialized(base::RunLoop* loop) {
49 called_back_ = true; 55 called_back_ = true;
50 loop->Quit(); 56 loop->Quit();
51 } 57 }
52 58
53 scoped_ptr<LocalDeviceInfoProviderImpl> provider_; 59 scoped_ptr<LocalDeviceInfoProviderImpl> provider_;
54 60
55 bool called_back_; 61 bool called_back_;
56 62
57 private: 63 private:
58 base::MessageLoop message_loop_; 64 base::MessageLoop message_loop_;
59 }; 65 };
60 66
61 TEST_F(LocalDeviceInfoProviderTest, OnInitializedCallback) { 67 TEST_F(SyncLocalDeviceInfoProviderTest, OnInitializedCallback) {
62 ASSERT_FALSE(called_back_); 68 ASSERT_FALSE(called_back_);
63 69
64 InitializeProvider(); 70 InitializeProvider();
65 EXPECT_TRUE(called_back_); 71 EXPECT_TRUE(called_back_);
66 } 72 }
67 73
68 TEST_F(LocalDeviceInfoProviderTest, GetLocalDeviceInfo) { 74 TEST_F(SyncLocalDeviceInfoProviderTest, GetLocalDeviceInfo) {
69 ASSERT_EQ(NULL, provider_->GetLocalDeviceInfo()); 75 ASSERT_EQ(NULL, provider_->GetLocalDeviceInfo());
70 76
71 InitializeProvider(); 77 InitializeProvider();
72 78
73 const DeviceInfo* local_device_info = provider_->GetLocalDeviceInfo(); 79 const DeviceInfo* local_device_info = provider_->GetLocalDeviceInfo();
74 EXPECT_TRUE(local_device_info); 80 EXPECT_TRUE(local_device_info);
75 EXPECT_EQ(std::string(kLocalDeviceGuid), local_device_info->guid()); 81 EXPECT_EQ(std::string(kLocalDeviceGuid), local_device_info->guid());
76 EXPECT_EQ(std::string(kSigninScopedDeviceId), 82 EXPECT_EQ(std::string(kSigninScopedDeviceId),
77 local_device_info->signin_scoped_device_id()); 83 local_device_info->signin_scoped_device_id());
78 EXPECT_EQ(syncer::GetSessionNameSynchronouslyForTesting(), 84 EXPECT_EQ(syncer::GetSessionNameSynchronouslyForTesting(),
79 local_device_info->client_name()); 85 local_device_info->client_name());
80 86
81 EXPECT_EQ(provider_->GetSyncUserAgent(), 87 EXPECT_EQ(provider_->GetSyncUserAgent(),
82 local_device_info->sync_user_agent()); 88 local_device_info->sync_user_agent());
83 } 89 }
84 90
85 TEST_F(LocalDeviceInfoProviderTest, GetLocalSyncCacheGUID) { 91 TEST_F(SyncLocalDeviceInfoProviderTest, GetLocalSyncCacheGUID) {
86 ASSERT_EQ(std::string(), provider_->GetLocalSyncCacheGUID()); 92 ASSERT_EQ(std::string(), provider_->GetLocalSyncCacheGUID());
87 93
88 InitializeProvider(); 94 InitializeProvider();
89 95
90 EXPECT_EQ(std::string(kLocalDeviceGuid), provider_->GetLocalSyncCacheGUID()); 96 EXPECT_EQ(std::string(kLocalDeviceGuid), provider_->GetLocalSyncCacheGUID());
91 } 97 }
92 98
93 } // namespace browser_sync 99 } // namespace browser_sync
OLDNEW
« no previous file with comments | « components/sync_driver/local_device_info_provider_mock.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698