Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1397903004: options: Fix async font fetching crash (Closed)

Created:
5 years, 2 months ago by Dan Beam
Modified:
5 years, 2 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, dbeam+watch-options_chromium.org, michaelpg+watch-options_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

options: Fix async font fetching crash R=thestig@chromium.org BUG=none TEST=less crashes with this signature Committed: https://crrev.com/bf8ba01d456b0d38e6bb88560f932cc9ab5f0714 Cr-Commit-Position: refs/heads/master@{#354215}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M chrome/browser/ui/webui/options/font_settings_handler.h View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/options/font_settings_handler.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Dan Beam
5 years, 2 months ago (2015-10-15 02:12:31 UTC) #1
Dan Beam
+thestig, -bondd
5 years, 2 months ago (2015-10-15 02:29:31 UTC) #3
Lei Zhang
lgtm
5 years, 2 months ago (2015-10-15 02:46:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1397903004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1397903004/1
5 years, 2 months ago (2015-10-15 03:41:10 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-15 03:50:02 UTC) #7
commit-bot: I haz the power
5 years, 2 months ago (2015-10-15 03:51:10 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/bf8ba01d456b0d38e6bb88560f932cc9ab5f0714
Cr-Commit-Position: refs/heads/master@{#354215}

Powered by Google App Engine
This is Rietveld 408576698