Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Unified Diff: gm/tests/rebaseline.sh

Issue 13979017: GM self-tests: always run all tests (don't stop at first failure) (Closed) Base URL: http://skia.googlecode.com/svn/trunk/
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | gm/tests/run.sh » ('j') | gm/tests/run.sh » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gm/tests/rebaseline.sh
===================================================================
--- gm/tests/rebaseline.sh (revision 8878)
+++ gm/tests/rebaseline.sh (working copy)
@@ -4,9 +4,6 @@
# gm self-tests.
# Use with caution: are you sure the new results are actually correct?
#
-# YOU MUST RE-RUN THIS UNTIL THE SELF-TESTS SUCCEED!
-# (It takes one run for each failing call to gm_test in run.sh)
-#
# TODO: currently, this must be run on Linux to generate baselines that match
# the ones on the housekeeper bot (which runs on Linux... see
# http://70.32.156.51:10117/builders/Skia_PerCommit_House_Keeping/builds/1417/steps/RunGmSelfTests/logs/stdio )
@@ -64,11 +61,11 @@
echo
if [ "$SELFTEST_RESULT" != "0" ]; then
replace_expected_with_actual
- echo "Self-tests still failing, you should probably run this again..."
-else
svn_add_new_files
svn_delete_old_files
- echo "Self-tests succeeded this time, you should be done!"
+ echo "Rebaseline completed. If you run run.sh now, it should succeed."
+else
+ echo "Self-tests succeeded, nothing to rebaseline."
fi
exit $SELFTEST_RESULT
« no previous file with comments | « no previous file | gm/tests/run.sh » ('j') | gm/tests/run.sh » ('J')

Powered by Google App Engine
This is Rietveld 408576698