Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issue 13979005: Only make OpenSSL a component for Android component builds. (Closed)

Created:
7 years, 8 months ago by Yaron
Modified:
7 years, 8 months ago
Reviewers:
digit1
Base URL:
https://chromium.googlesource.com/chromium/deps/openssl.git@master
Visibility:
Public.

Description

Only make OpenSSL a component for Android component builds. Fixes an issue with attempted roll see on linux_clang: http://build.chromium.org/p/tryserver.chromium/builders/linux_clang/builds/97781 BUG=158821 Committed: 194187

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : component on android #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M openssl.gyp View 1 2 2 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Yaron
I thought openssl was only used on Android. Anyway, updated the previous change to only ...
7 years, 8 months ago (2013-04-10 21:38:41 UTC) #1
digit1
Cautious lgtm (see comments below). Ah yes, it's also used on the host for the ...
7 years, 8 months ago (2013-04-10 23:12:11 UTC) #2
Yaron
On 2013/04/10 23:12:11, digit1 wrote: > Cautious lgtm (see comments below). > > Ah yes, ...
7 years, 8 months ago (2013-04-10 23:14:41 UTC) #3
Yaron
ok, verified that this only affects android now. I don't know what to make of ...
7 years, 8 months ago (2013-04-11 20:27:40 UTC) #4
Yaron
7 years, 8 months ago (2013-04-15 16:44:25 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as r194187 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698