chrome/browser/ui/cocoa/browser_window_cocoa.mm - Issue 13979003: Win: Display a native bubble (instead of the JS one) after the web signin flow.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/browser_window_cocoa.mm

Issue 13979003: Win: Display a native bubble (instead of the JS one) after the web signin flow. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed/reenabled browser tests (hopefully) Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/browser_window_cocoa.h ('k') | chrome/browser/ui/gtk/browser_window_gtk.h » ('j') | chrome/browser/ui/views/sync/one_click_signin_bubble_view.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/browser_window_cocoa.mm

diff --git a/chrome/browser/ui/cocoa/browser_window_cocoa.mm b/chrome/browser/ui/cocoa/browser_window_cocoa.mm

index a199f222efaeed0e38b383ce3857eaeba947585c..f0b97b0485da01700203bb8c400208b733db37ff 100644

--- a/chrome/browser/ui/cocoa/browser_window_cocoa.mm

+++ b/chrome/browser/ui/cocoa/browser_window_cocoa.mm

@@ -480,7 +480,9 @@ void BrowserWindowCocoa::ShowChromeToMobileBubble() {

void BrowserWindowCocoa::ShowOneClickSigninBubble(

OneClickSigninBubbleType type,

const string16& email,

- const StartSyncCallback& start_sync_callback) {

+ const StartSyncCallback& start_sync_callback,

+ const std::string& error_message

+ ) {

bcwhite 2013/04/16 15:22:00 Move up on previous line.

noms (inactive) 2013/04/16 17:15:37 Done.

if (type == ONE_CLICK_SIGNIN_BUBBLE_TYPE_BUBBLE) {

scoped_nsobject<OneClickSigninBubbleController> bubble_controller(

[[OneClickSigninBubbleController alloc]