Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Unified Diff: net/base/static_cookie_policy.cc

Issue 13979002: Add support for split PSL list distinctions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Added const modifiers Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/base/static_cookie_policy.cc
diff --git a/net/base/static_cookie_policy.cc b/net/base/static_cookie_policy.cc
index 55f45306d00d62e89edf57afe5d6d6fe105953bc..58ae36ee481c83269faa34024af61d3c6669e392 100644
--- a/net/base/static_cookie_policy.cc
+++ b/net/base/static_cookie_policy.cc
@@ -21,8 +21,11 @@ int StaticCookiePolicy::CanGetCookies(
case StaticCookiePolicy::BLOCK_ALL_THIRD_PARTY_COOKIES:
if (first_party_for_cookies.is_empty())
return OK; // Empty first-party URL indicates a first-party request.
- return RegistryControlledDomainService::SameDomainOrHost(
- url, first_party_for_cookies) ? OK : ERR_ACCESS_DENIED;
+ return registry_controlled_domains::SameDomainOrHost(
+ url,
+ first_party_for_cookies,
+ registry_controlled_domains::EXCLUDE_PRIVATE_REGISTRIES) ?
+ OK : ERR_ACCESS_DENIED;
Ryan Sleevi 2013/05/06 21:23:13 style nit: +4 spaces
nyquist 2013/05/06 22:30:56 Done.
case StaticCookiePolicy::BLOCK_ALL_COOKIES:
return ERR_ACCESS_DENIED;
default:
@@ -41,8 +44,11 @@ int StaticCookiePolicy::CanSetCookie(
case StaticCookiePolicy::BLOCK_ALL_THIRD_PARTY_COOKIES:
if (first_party_for_cookies.is_empty())
return OK; // Empty first-party URL indicates a first-party request.
- return RegistryControlledDomainService::SameDomainOrHost(
- url, first_party_for_cookies) ? OK : ERR_ACCESS_DENIED;
+ return registry_controlled_domains::SameDomainOrHost(
+ url,
+ first_party_for_cookies,
+ registry_controlled_domains::EXCLUDE_PRIVATE_REGISTRIES) ?
+ OK : ERR_ACCESS_DENIED;
Ryan Sleevi 2013/05/06 21:23:13 style nit: +4 spaces
nyquist 2013/05/06 22:30:56 Done.
case StaticCookiePolicy::BLOCK_ALL_COOKIES:
return ERR_ACCESS_DENIED;
default:

Powered by Google App Engine
This is Rietveld 408576698