Add support for split PSL list distinctions.

chrome/browser/autocomplete/autocomplete_input.cc

Index: chrome/browser/autocomplete/autocomplete_input.cc
diff --git a/chrome/browser/autocomplete/autocomplete_input.cc b/chrome/browser/autocomplete/autocomplete_input.cc
index f6c039ce01eb77aeaff7c9e38c92d72b80f3db7e..13ad7537cad36c84ec24da2ee4ee73ffbda54f8d 100644
--- a/chrome/browser/autocomplete/autocomplete_input.cc
+++ b/chrome/browser/autocomplete/autocomplete_input.cc
@@ -266,8 +266,10 @@ AutocompleteInput::Type AutocompleteInput::Parse(
   // use the registry length later below.)
   const string16 host(text.substr(parts->host.begin, parts->host.len));
   const size_t registry_length =
-      net::RegistryControlledDomainService::GetRegistryLength(UTF16ToUTF8(host),
-                                                              false);
+      net::RegistryControlledDomainService::GetRegistryLength(
+          UTF16ToUTF8(host),
+          net::RCDS::EXCLUDE_UNKNOWN_REGISTRIES,
+          net::RCDS::EXCLUDE_PRIVATE_REGISTRIES);
   if (registry_length == std::string::npos) {
     // Try to append the desired_tld.
     if (!desired_tld.empty()) {
@@ -275,8 +277,12 @@ AutocompleteInput::Type AutocompleteInput::Parse(
       if (host[host.length() - 1] != '.')
         host_with_tld += '.';
       host_with_tld += desired_tld;
-      if (net::RegistryControlledDomainService::GetRegistryLength(
-          UTF16ToUTF8(host_with_tld), false) != std::string::npos)
+      size_t tld_length =

[sky, 2013/04/26 20:02:27]

const

[Pam (message me for reviews), 2013/04/29 09:25:56]

Interesting. It's clear what that does, but it's not customary to use 'const'
like this (that is to say, I don't think I've ever seen it before, other than
just above). What are the advantages, and why would one choose to do it (add
'const') or not?

[sky, 2013/04/29 16:08:30]

http://www.corp.google.com/eng/doc/cppguide.xml#Use_of_const

const makers it clear the value isn't going to change for the life of the
function. I personally find this very helpful when looking at random function as
a way to know a particular value doesn't change. In this particular case it
isn't that useful since the scope of tld_length is very narrow. But just as with
scoped_ptr things change over time.

The use of const inside of functions varies drastically based on the author of
the file. Peter strongly favors const. You  can see its use in other similar
places in the code here (267/268...) which is why I only pointed this out in
files that tend to use const like this.

+          net::RegistryControlledDomainService::GetRegistryLength(
+              UTF16ToUTF8(host_with_tld),
+              net::RCDS::EXCLUDE_UNKNOWN_REGISTRIES,
+              net::RCDS::EXCLUDE_PRIVATE_REGISTRIES);
+      if (tld_length != std::string::npos)
         return URL;  // Something like "99999999999" that looks like a bad IP
                      // address, but becomes valid on attaching a TLD.
     }