Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 1397883007: Don't cleanup thread list mutex until VM shutdown is clean (Closed)

Created:
5 years, 2 months ago by Cutch
Modified:
5 years, 2 months ago
Reviewers:
Bill Hesse, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Don't cleanup thread list mutex until VM shutdown is clean - We had a race where the thread pool would be starting up a thread while Dart::Cleanup was running on the main thread. - The mutex used to guard the thread list was being deleted and set to NULL. - Thread would try and add itself to the list and die when attempting to lock the mutex. This CL does two things: - Moves Thread list mutex cleanup to only run under FLAG_shutdown. - Fixes a forgotten NULL initilization of thread list mutex. R=whesse@google.com Committed: https://github.com/dart-lang/sdk/commit/7803350a23beb025739c00ba19859a826d556926

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M runtime/vm/dart.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/thread.cc View 4 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Bill Hesse
lgtm
5 years, 2 months ago (2015-10-13 21:41:10 UTC) #2
Cutch
Committed patchset #1 (id:1) manually as 7803350a23beb025739c00ba19859a826d556926 (presubmit successful).
5 years, 2 months ago (2015-10-13 21:44:15 UTC) #3
siva
5 years, 2 months ago (2015-10-13 21:44:20 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698