Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 1397883003: Added a test for CLZ (Closed)

Created:
5 years, 2 months ago by ahaas
Modified:
5 years, 2 months ago
Reviewers:
ahaas1, titzer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Added a test for CLZ Committed: https://crrev.com/dd1928ca8986d316203d451c73eec9e7ef26c1cb Cr-Commit-Position: refs/heads/master@{#31316}

Patch Set 1 #

Patch Set 2 : Changed the type of a parameter to avoid compilation problems. #

Patch Set 3 : Merge conflict #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -0 lines) Patch
M test/cctest/compiler/test-run-machops.cc View 1 2 1 chunk +45 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1397883003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1397883003/1
5 years, 2 months ago (2015-10-12 21:35:26 UTC) #2
commit-bot: I haz the power
Dry run: No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even ...
5 years, 2 months ago (2015-10-12 21:35:28 UTC) #4
ahaas1
5 years, 2 months ago (2015-10-12 21:35:47 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1397883003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1397883003/1
5 years, 2 months ago (2015-10-12 21:37:05 UTC) #8
commit-bot: I haz the power
Dry run: No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even ...
5 years, 2 months ago (2015-10-12 21:37:07 UTC) #10
titzer
lgtm
5 years, 2 months ago (2015-10-15 16:56:12 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1397883003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1397883003/20001
5 years, 2 months ago (2015-10-15 16:58:09 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: v8_win_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel/builds/10675)
5 years, 2 months ago (2015-10-15 17:24:32 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1397883003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1397883003/40001
5 years, 2 months ago (2015-10-15 18:36:02 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 2 months ago (2015-10-15 18:37:05 UTC) #19
commit-bot: I haz the power
5 years, 2 months ago (2015-10-15 18:37:32 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/dd1928ca8986d316203d451c73eec9e7ef26c1cb
Cr-Commit-Position: refs/heads/master@{#31316}

Powered by Google App Engine
This is Rietveld 408576698