Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Unified Diff: src/builtins.cc

Issue 1397853005: [es6] Partially implement Reflect.preventExtensions. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: s/Object/JSObject/ Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/builtins.h ('k') | src/isolate.h » ('j') | src/isolate.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/builtins.cc
diff --git a/src/builtins.cc b/src/builtins.cc
index b672185792c417a75f311c7ea6b35d880f91f6a4..8302469e16ea7edea384ee39e25d82e1699d7287 100644
--- a/src/builtins.cc
+++ b/src/builtins.cc
@@ -1517,10 +1517,10 @@ BUILTIN(ReflectHas) {
ASSIGN_RETURN_FAILURE_ON_EXCEPTION(isolate, name,
Object::ToName(isolate, key));
- Maybe<bool> maybe =
- JSReceiver::HasProperty(Handle<JSReceiver>::cast(target), name);
- if (!maybe.IsJust()) return isolate->heap()->exception();
- return *isolate->factory()->ToBoolean(maybe.FromJust());
+ ASSIGN_OR_RETURN_EXCEPTION(
+ isolate, bool, result,
+ JSReceiver::HasProperty(Handle<JSReceiver>::cast(target), name));
+ return *isolate->factory()->ToBoolean(result);
}
@@ -1554,6 +1554,26 @@ BUILTIN(ReflectIsExtensible) {
}
+// ES6 section 26.1.12 Reflect.preventExtensions
+BUILTIN(ReflectPreventExtensions) {
+ HandleScope scope(isolate);
+ DCHECK_EQ(2, args.length());
+ Handle<Object> target = args.at<Object>(1);
+
+ if (!target->IsJSReceiver()) {
+ THROW_NEW_ERROR_RETURN_FAILURE(
+ isolate, NewTypeError(MessageTemplate::kCalledOnNonObject,
+ isolate->factory()->NewStringFromAsciiChecked(
+ "Reflect.preventExtensions")));
+ }
+
+ ASSIGN_OR_RETURN_EXCEPTION(
+ isolate, bool, result,
+ JSObject::PreventExtensions(Handle<JSObject>::cast(target), DONT_THROW));
rossberg 2015/10/19 14:33:08 JSReceiver:: ?
neis 2015/10/20 07:58:35 Done.
+ return *isolate->factory()->ToBoolean(result);
+}
+
+
// ES6 section 20.3.4.45 Date.prototype [ @@toPrimitive ] ( hint )
BUILTIN(DateToPrimitive) {
HandleScope scope(isolate);
« no previous file with comments | « src/builtins.h ('k') | src/isolate.h » ('j') | src/isolate.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698