Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Unified Diff: src/builtins.cc

Issue 1397853005: [es6] Partially implement Reflect.preventExtensions. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/builtins.h ('k') | src/isolate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/builtins.cc
diff --git a/src/builtins.cc b/src/builtins.cc
index b672185792c417a75f311c7ea6b35d880f91f6a4..ce603bd7f7cca34aa3f42194ce45bc5ee8401f96 100644
--- a/src/builtins.cc
+++ b/src/builtins.cc
@@ -1554,6 +1554,32 @@ BUILTIN(ReflectIsExtensible) {
}
+// ES6 section 26.1.12 Reflect.preventExtensions
+BUILTIN(ReflectPreventExtensions) {
+ HandleScope scope(isolate);
+ DCHECK_EQ(2, args.length());
+ Handle<Object> target = args.at<Object>(1);
+
+ if (!target->IsJSReceiver()) {
+ THROW_NEW_ERROR_RETURN_FAILURE(
+ isolate, NewTypeError(MessageTemplate::kCalledOnNonObject,
+ isolate->factory()->NewStringFromAsciiChecked(
+ "Reflect.preventExtensions")));
+ }
+
+ // TODO(neis): For now, we ignore proxies.
rossberg 2015/10/15 10:54:40 Actually, the case distinction should not be made
+
+ if (target->IsJSObject()) {
+ bool result;
+ MAYBE_ASSIGN_RETURN_ON_EXCEPTION(
+ isolate, bool, result,
+ JSObject::PreventExtensionsInternal(Handle<JSObject>::cast(target)));
+ return *isolate->factory()->ToBoolean(result);
+ }
+ return *isolate->factory()->false_value();
+}
+
+
// ES6 section 20.3.4.45 Date.prototype [ @@toPrimitive ] ( hint )
BUILTIN(DateToPrimitive) {
HandleScope scope(isolate);
« no previous file with comments | « src/builtins.h ('k') | src/isolate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698