Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1452)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1397853005: [es6] Partially implement Reflect.preventExtensions. (Closed)

Created:
5 years, 2 months ago by neis
Modified:
5 years, 2 months ago
Reviewers:
rossberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[es6] Partially implement Reflect.preventExtensions. Ignore proxies for now. R=rossberg BUG=v8:3931 LOG=n Committed: https://crrev.com/79634a3ffef3dae3e81bedd48fe8da6ba98cd52b Cr-Commit-Position: refs/heads/master@{#31431}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebase. #

Patch Set 3 : Add JSReceiver dispatcher and use ShouldThrow. #

Patch Set 4 : s/Object/JSObject/ #

Total comments: 6

Patch Set 5 : Address comments. #

Patch Set 6 : Rebase. #

Patch Set 7 : Get rid of macro. #

Patch Set 8 : Get rid of the other one too. #

Patch Set 9 : Sorry #

Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -61 lines) Patch
M src/bootstrapper.cc View 1 2 3 4 5 6 7 8 2 chunks +4 lines, -1 line 0 comments Download
M src/builtins.h View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M src/builtins.cc View 1 2 3 4 5 6 7 8 2 chunks +23 lines, -3 lines 0 comments Download
M src/objects.h View 1 2 3 4 5 3 chunks +8 lines, -6 lines 0 comments Download
M src/objects.cc View 1 2 3 4 5 6 7 8 7 chunks +40 lines, -28 lines 0 comments Download
M src/runtime/runtime-object.cc View 1 2 3 4 5 6 7 8 1 chunk +4 lines, -5 lines 0 comments Download
M src/runtime/runtime-scopes.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M test/mjsunit/harmony/reflect.js View 1 2 3 4 5 2 chunks +24 lines, -1 line 0 comments Download
A + test/mjsunit/harmony/reflect-prevent-extensions.js View 9 chunks +17 lines, -15 lines 0 comments Download
M test/mjsunit/object-prevent-extensions.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 33 (14 generated)
neis
5 years, 2 months ago (2015-10-13 09:07:32 UTC) #1
rossberg
https://codereview.chromium.org/1397853005/diff/1/src/builtins.cc File src/builtins.cc (right): https://codereview.chromium.org/1397853005/diff/1/src/builtins.cc#newcode1570 src/builtins.cc:1570: // TODO(neis): For now, we ignore proxies. Actually, the ...
5 years, 2 months ago (2015-10-15 10:54:40 UTC) #2
neis
On 2015/10/15 10:54:40, rossberg wrote: > https://codereview.chromium.org/1397853005/diff/1/src/builtins.cc > File src/builtins.cc (right): > > https://codereview.chromium.org/1397853005/diff/1/src/builtins.cc#newcode1570 > ...
5 years, 2 months ago (2015-10-19 08:40:28 UTC) #3
rossberg
https://codereview.chromium.org/1397853005/diff/60001/src/builtins.cc File src/builtins.cc (right): https://codereview.chromium.org/1397853005/diff/60001/src/builtins.cc#newcode1572 src/builtins.cc:1572: JSObject::PreventExtensions(Handle<JSObject>::cast(target), DONT_THROW)); JSReceiver:: ? https://codereview.chromium.org/1397853005/diff/60001/src/isolate.h File src/isolate.h (right): https://codereview.chromium.org/1397853005/diff/60001/src/isolate.h#newcode170 ...
5 years, 2 months ago (2015-10-19 14:33:08 UTC) #4
neis
https://codereview.chromium.org/1397853005/diff/60001/src/builtins.cc File src/builtins.cc (right): https://codereview.chromium.org/1397853005/diff/60001/src/builtins.cc#newcode1572 src/builtins.cc:1572: JSObject::PreventExtensions(Handle<JSObject>::cast(target), DONT_THROW)); On 2015/10/19 14:33:08, rossberg wrote: > JSReceiver:: ...
5 years, 2 months ago (2015-10-20 07:58:35 UTC) #5
rossberg
lgtm
5 years, 2 months ago (2015-10-20 09:09:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1397853005/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1397853005/80001
5 years, 2 months ago (2015-10-20 09:24:49 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_gcc_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/builds/7449) v8_linux_mipsel_compile_rel on tryserver.v8 (JOB_FAILED, ...
5 years, 2 months ago (2015-10-20 09:25:47 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1397853005/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1397853005/100001
5 years, 2 months ago (2015-10-20 10:40:39 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_gcc_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/builds/7457)
5 years, 2 months ago (2015-10-20 10:49:11 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1397853005/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1397853005/120001
5 years, 2 months ago (2015-10-20 13:28:41 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_gcc_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/builds/7466)
5 years, 2 months ago (2015-10-20 13:37:23 UTC) #20
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1397853005/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1397853005/140001
5 years, 2 months ago (2015-10-21 07:21:48 UTC) #22
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_mips64el_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_rel/builds/5799) v8_linux_mipsel_compile_rel on ...
5 years, 2 months ago (2015-10-21 07:23:36 UTC) #24
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1397853005/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1397853005/160001
5 years, 2 months ago (2015-10-21 08:53:30 UTC) #26
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-21 09:20:20 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1397853005/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1397853005/160001
5 years, 2 months ago (2015-10-21 09:22:01 UTC) #31
commit-bot: I haz the power
Committed patchset #9 (id:160001)
5 years, 2 months ago (2015-10-21 09:23:42 UTC) #32
commit-bot: I haz the power
5 years, 2 months ago (2015-10-21 09:23:59 UTC) #33
Message was sent while issue was closed. 
Patchset 9 (id:??) landed as
https://crrev.com/79634a3ffef3dae3e81bedd48fe8da6ba98cd52b
Cr-Commit-Position: refs/heads/master@{#31431}

Powered by Google App Engine
This is Rietveld 408576698