Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 1397843002: Added Network Quality Estimator Real-time interface to Cronet (Closed)

Created:
5 years, 2 months ago by mef
Modified:
5 years, 2 months ago
Reviewers:
pauljensen, bengr
CC:
chromium-reviews, asanka, benjhayden+dwatch_chromium.org, cbentzel+watch_chromium.org, Randy Smith (Not in Mondays)
Base URL:
https://chromium.googlesource.com/chromium/src.git@2526
Target Ref:
refs/pending/branch-heads/2526
Project:
chromium
Visibility:
Public.

Description

Added Network Quality Estimator Real-time interface to Cronet BUG=502423 Review URL: https://codereview.chromium.org/1273173002 Cr-Commit-Position: refs/heads/master@{#352732} (cherry picked from commit f1b6738e27e2e31e5f8da99f3367ccb3d3c2911f) R=bengr@chromium.org, pauljensen@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/e51b4528666963e450e54a13495eb5737cabe2ea

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+880 lines, -63 lines) Patch
M components/cronet.gypi View 4 chunks +12 lines, -0 lines 0 comments Download
M components/cronet/android/cronet_url_request_context_adapter.h View 5 chunks +48 lines, -2 lines 0 comments Download
M components/cronet/android/cronet_url_request_context_adapter.cc View 6 chunks +95 lines, -0 lines 0 comments Download
M components/cronet/android/java/build.xml View 1 chunk +1 line, -0 lines 0 comments Download
M components/cronet/android/java/src/org/chromium/net/CronetUrlRequestContext.java View 6 chunks +160 lines, -0 lines 0 comments Download
A components/cronet/android/java/src/org/chromium/net/NetworkQualityRttListener.java View 1 chunk +21 lines, -0 lines 0 comments Download
A components/cronet/android/java/src/org/chromium/net/NetworkQualityThroughputListener.java View 1 chunk +18 lines, -0 lines 0 comments Download
M components/cronet/android/java/src/org/chromium/net/UrlRequestContext.java View 1 chunk +76 lines, -0 lines 0 comments Download
M components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java View 3 chunks +112 lines, -0 lines 0 comments Download
M net/base/network_quality_estimator.h View 10 chunks +115 lines, -21 lines 0 comments Download
M net/base/network_quality_estimator.cc View 7 chunks +74 lines, -18 lines 0 comments Download
M net/base/network_quality_estimator_unittest.cc View 11 chunks +148 lines, -22 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
mef
PTAL, cherry-picking NQE into M47.
5 years, 2 months ago (2015-10-08 19:24:21 UTC) #2
bengr
LGTM. Thanks for doing this.
5 years, 2 months ago (2015-10-09 16:18:35 UTC) #3
pauljensen
lgtm
5 years, 2 months ago (2015-10-09 16:28:18 UTC) #4
mef
5 years, 2 months ago (2015-10-09 16:32:55 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e51b4528666963e450e54a13495eb5737cabe2ea (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698