Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Issue 139783014: Parse blink platform log channel command line args in webkit unit tests. (Closed)

Created:
6 years, 10 months ago by gavinp
Modified:
6 years, 10 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Parse blink platform log channel command line args in webkit unit tests. This should make debugging webkit unit tests a bit easier. R=jochen@chromium.org,japhet@chromium.org BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248877

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -1 line) Patch
M content/public/common/content_switches.h View 1 chunk +1 line, -1 line 0 comments Download
M content/test/webkit_support.cc View 3 chunks +21 lines, -0 lines 0 comments Download

Messages

Total messages: 25 (0 generated)
gavinp
jochen: PTAL. japhet: FYI. This is downstream of https://codereview.chromium.org/152873002/ .
6 years, 10 months ago (2014-02-03 16:17:23 UTC) #1
jochen (gone - plz use gerrit)
lgtm
6 years, 10 months ago (2014-02-03 18:55:43 UTC) #2
gavinp
The CQ bit was checked by gavinp@chromium.org
6 years, 10 months ago (2014-02-04 13:11:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gavinp@chromium.org/139783014/1
6 years, 10 months ago (2014-02-04 13:11:42 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-04 13:48:01 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) sync_integration_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=223134
6 years, 10 months ago (2014-02-04 13:48:02 UTC) #6
skia-commit-bot
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-04 13:48:23 UTC) #7
gavinp
The CQ bit was checked by gavinp@chromium.org
6 years, 10 months ago (2014-02-04 14:23:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gavinp@chromium.org/139783014/1
6 years, 10 months ago (2014-02-04 14:23:47 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-04 15:28:31 UTC) #10
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) url_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=120822
6 years, 10 months ago (2014-02-04 15:28:31 UTC) #11
skia-commit-bot
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-04 15:28:35 UTC) #12
gavinp
The CQ bit was checked by gavinp@chromium.org
6 years, 10 months ago (2014-02-04 15:31:47 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gavinp@chromium.org/139783014/1
6 years, 10 months ago (2014-02-04 15:33:59 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-04 16:53:41 UTC) #15
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) url_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=120888
6 years, 10 months ago (2014-02-04 16:53:42 UTC) #16
gavinp
The CQ bit was checked by gavinp@chromium.org
6 years, 10 months ago (2014-02-04 18:51:42 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gavinp@chromium.org/139783014/1
6 years, 10 months ago (2014-02-04 18:54:20 UTC) #18
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-04 22:51:43 UTC) #19
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, sync_integration_tests, unit_tests ...
6 years, 10 months ago (2014-02-04 22:51:44 UTC) #20
gavinp
The CQ bit was checked by gavinp@chromium.org
6 years, 10 months ago (2014-02-04 22:52:36 UTC) #21
gavinp
On 2014/02/04 22:51:44, I haz the power (commit-bot) wrote: > Retried try job too often ...
6 years, 10 months ago (2014-02-04 22:52:44 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gavinp@chromium.org/139783014/1
6 years, 10 months ago (2014-02-04 22:57:06 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gavinp@chromium.org/139783014/1
6 years, 10 months ago (2014-02-05 01:22:20 UTC) #24
commit-bot: I haz the power
6 years, 10 months ago (2014-02-05 06:28:09 UTC) #25
Message was sent while issue was closed.
Change committed as 248877

Powered by Google App Engine
This is Rietveld 408576698