Issue 139783012: Add support for Dr memory in the GN build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 139783012: Add support for Dr memory in the GN build. (Closed)

Created:
6 years, 11 months ago by brettw

Modified:
6 years, 11 months ago

Reviewers:
scottmg

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add support for Dr memory and Windows tsan in the GN build. This generalizes the GCC iterator debugging flag to now be platform-independent. R=scottmg@chromium.org TBR=scottmg Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245665

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -8 lines)			Patch
	M	build/config/BUILD.gn	View		3 chunks	+12 lines, -7 lines	1 comment	Download
	M	build/gyp_chromium	View	1	1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brettw@chromium.org/139783012/30001

6 years, 11 months ago (2014-01-17 23:50:06 UTC) #2

scottmg

lgtm https://codereview.chromium.org/139783012/diff/30001/build/config/BUILD.gn File build/config/BUILD.gn (right): https://codereview.chromium.org/139783012/diff/30001/build/config/BUILD.gn#newcode7 build/config/BUILD.gn:7: # that is normall turned on for Debug ...

6 years, 11 months ago (2014-01-17 23:52:25 UTC) #3

brettw

6 years, 11 months ago (2014-01-18 00:01:19 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r245665 (tree was closed).

Expand Messages | Collapse Messages