Issue 139783004: drive: Do not clear dirty bit if someone is writing to the file

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 139783004: drive: Do not clear dirty bit if someone is writing to the file (Closed)

Created:
6 years, 11 months ago by hashimoto

Modified:
6 years, 11 months ago

Reviewers:
kinaba

CC:
chromium-reviews, nkostylev+watch_chromium.org, tzik, tfarina, nhiroki, oshima+watch_chromium.org, kinuko+watch, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

drive: Do not clear dirty bit if someone is writing to the file Keeping the cache entry dirty to make sure that the edited file will eventually be uploaded. BUG=326054 TEST=unit_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245277

Patch Set 1 : #

Total comments: 1

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+135 lines, -87 lines)			Patch
	M	chrome/browser/chromeos/drive/file_system/update_operation.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download
	M	chrome/browser/chromeos/drive/file_system/update_operation_unittest.cc	View		5 chunks	+132 lines, -86 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

hashimoto

https://codereview.chromium.org/139783004/diff/30001/chrome/browser/chromeos/drive/file_system/update_operation_unittest.cc File chrome/browser/chromeos/drive/file_system/update_operation_unittest.cc (left): https://codereview.chromium.org/139783004/diff/30001/chrome/browser/chromeos/drive/file_system/update_operation_unittest.cc#oldcode46 chrome/browser/chromeos/drive/file_system/update_operation_unittest.cc:46: // Pin the file so it'll be store in ...

6 years, 11 months ago (2014-01-16 05:47:31 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/139783004/30001

6 years, 11 months ago (2014-01-16 06:31:02 UTC) #3

Message was sent while issue was closed.

Change committed as 245277

Expand Messages | Collapse Messages