Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(766)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1397823002: Add support for emitting asynchronous timeline events from Dart code (Closed)

Created:
5 years, 2 months ago by Cutch
Modified:
5 years, 2 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add support for emitting asynchronous timeline events from Dart code BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/1a0066816dcb9458f2bd115df460577b3b16b977

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 2

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+202 lines, -12 lines) Patch
M runtime/lib/timeline.cc View 1 2 3 4 2 chunks +51 lines, -1 line 0 comments Download
M runtime/lib/timeline.dart View 1 chunk +10 lines, -0 lines 0 comments Download
M runtime/vm/bootstrap_natives.h View 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/developer/timeline.dart View 1 2 3 4 chunks +139 lines, -11 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Cutch
5 years, 2 months ago (2015-10-08 18:19:53 UTC) #2
rmacnak
lgtm w/c https://chromiumcodereview.appspot.com/1397823002/diff/60001/runtime/lib/timeline.cc File runtime/lib/timeline.cc (right): https://chromiumcodereview.appspot.com/1397823002/diff/60001/runtime/lib/timeline.cc#newcode34 runtime/lib/timeline.cc:34: return Object::null(); I think argument checking should ...
5 years, 2 months ago (2015-10-09 17:15:42 UTC) #3
Cutch
https://chromiumcodereview.appspot.com/1397823002/diff/60001/runtime/lib/timeline.cc File runtime/lib/timeline.cc (right): https://chromiumcodereview.appspot.com/1397823002/diff/60001/runtime/lib/timeline.cc#newcode34 runtime/lib/timeline.cc:34: return Object::null(); On 2015/10/09 17:15:42, rmacnak wrote: > I ...
5 years, 2 months ago (2015-10-09 17:19:26 UTC) #4
Cutch
5 years, 2 months ago (2015-10-09 17:21:06 UTC) #5
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) manually as
1a0066816dcb9458f2bd115df460577b3b16b977 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698