Issue 139773002: Remove some isPresentationAttribute implementations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 139773002: Remove some isPresentationAttribute implementations (Closed)

Created:
6 years, 11 months ago by rwlbuis

Modified:
6 years, 11 months ago

Reviewers:
Inactive

CC:
blink-reviews, dglazkov+blink, adamk+blink_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Remove some isPresentationAttribute implementations All of these seem to check alignAttr, but HTMLElement::isPresentationAttribute already checks it, so remove the complete implementations. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165169

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -24 lines)			Patch
M	Source/core/html/HTMLDivElement.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/html/HTMLDivElement.cpp	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	Source/core/html/HTMLParagraphElement.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/html/HTMLParagraphElement.cpp	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	Source/core/html/HTMLTableCaptionElement.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/html/HTMLTableCaptionElement.cpp	View	1 chunk	+0 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/139773002/1

6 years, 11 months ago (2014-01-15 20:15:54 UTC) #3

Message was sent while issue was closed.

Change committed as 165169

Expand Messages | Collapse Messages