third_party/WebKit/Source/web/tests/WebViewTest.cpp - Issue 1397713004: Don't bother layout until first navigation is done.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/WebViewTest.cpp

Issue 1397713004: Don't bother layout until first navigation is done. Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: another attempt to fix tests Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/tests/WebViewTest.cpp

diff --git a/third_party/WebKit/Source/web/tests/WebViewTest.cpp b/third_party/WebKit/Source/web/tests/WebViewTest.cpp

index 7c637ec32c45d8668e4b54f6f127da452f07bedf..acc11e5653bb5934e8583f1db75c1cf03e59da8c 100644

--- a/third_party/WebKit/Source/web/tests/WebViewTest.cpp

+++ b/third_party/WebKit/Source/web/tests/WebViewTest.cpp

@@ -2214,6 +2214,10 @@ TEST_F(WebViewTest, ChangeDisplayMode)

EXPECT_EQ("regular-ui", content);

webView->setDisplayMode(WebDisplayModeMinimalUi);

+ // Required to see any updates in dumpFrameTreeAsText.

+ m_webViewHelper.webView()->updateAllLifecyclePhases();

content = WebFrameContentDumper::dumpFrameTreeAsText(webView->mainFrame()->toWebLocalFrame(), 21).utf8();

EXPECT_EQ("minimal-ui", content);

m_webViewHelper.reset();