Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(650)

Unified Diff: content/renderer/render_view_browsertest.cc

Issue 1397713004: Don't bother layout until first navigation is done. Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: another attempt to fix tests Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/dom/Document.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_view_browsertest.cc
diff --git a/content/renderer/render_view_browsertest.cc b/content/renderer/render_view_browsertest.cc
index ba49266605de5233a33079313cb131afb9178af6..dcf209bdae58e6aa89f687cc3c37666716f8a1de 100644
--- a/content/renderer/render_view_browsertest.cc
+++ b/content/renderer/render_view_browsertest.cc
@@ -1436,6 +1436,9 @@ TEST_F(RenderViewImplTest, OnSetTextDirection) {
" node.getAttribute('dir') + ',' +"
" style.getPropertyValue('direction');");
+ // Required to see any updates in dumpFrameTreeAsText.
+ view()->GetWebView()->updateAllLifecyclePhases();
+
// Copy the document content to std::wstring and compare with the
// expected result.
const int kMaxOutputCharacters = 16;
@@ -1576,6 +1579,9 @@ TEST_F(RenderViewImplTest, OnHandleKeyboardEvent) {
kModifierData[j].expected_result,
key_code, kModifierData[j].expected_result);
+ // Required to see any updates in dumpFrameTreeAsText.
+ view()->GetWebView()->updateAllLifecyclePhases();
+
// Retrieve the text in the test page and compare it with the expected
// text created from a virtual-key code, a character code, and the
// modifier-key status.
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/dom/Document.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698