Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: src/x64/lithium-x64.cc

Issue 13977019: Fix HConstant::InNewSpace() for parallel compilation. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/lithium-ia32.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2228 matching lines...) Expand 10 before | Expand all | Expand 10 after
2239 obj = instr->is_in_object() 2239 obj = instr->is_in_object()
2240 ? UseRegister(instr->object()) 2240 ? UseRegister(instr->object())
2241 : UseTempRegister(instr->object()); 2241 : UseTempRegister(instr->object());
2242 } else { 2242 } else {
2243 obj = needs_write_barrier_for_map 2243 obj = needs_write_barrier_for_map
2244 ? UseRegister(instr->object()) 2244 ? UseRegister(instr->object())
2245 : UseRegisterAtStart(instr->object()); 2245 : UseRegisterAtStart(instr->object());
2246 } 2246 }
2247 2247
2248 bool can_be_constant = instr->value()->IsConstant() && 2248 bool can_be_constant = instr->value()->IsConstant() &&
2249 !HConstant::cast(instr->value())->InNewSpace() && 2249 HConstant::cast(instr->value())->NotInNewSpace() &&
2250 !(FLAG_track_double_fields && instr->field_representation().IsDouble()); 2250 !(FLAG_track_double_fields && instr->field_representation().IsDouble());
2251 2251
2252 LOperand* val; 2252 LOperand* val;
2253 if (needs_write_barrier) { 2253 if (needs_write_barrier) {
2254 val = UseTempRegister(instr->value()); 2254 val = UseTempRegister(instr->value());
2255 } else if (can_be_constant) { 2255 } else if (can_be_constant) {
2256 val = UseRegisterOrConstant(instr->value()); 2256 val = UseRegisterOrConstant(instr->value());
2257 } else if (FLAG_track_fields && instr->field_representation().IsSmi()) { 2257 } else if (FLAG_track_fields && instr->field_representation().IsSmi()) {
2258 val = UseTempRegister(instr->value()); 2258 val = UseTempRegister(instr->value());
2259 } else { 2259 } else {
(...skipping 302 matching lines...) Expand 10 before | Expand all | Expand 10 after
2562 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { 2562 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
2563 LOperand* object = UseRegister(instr->object()); 2563 LOperand* object = UseRegister(instr->object());
2564 LOperand* index = UseTempRegister(instr->index()); 2564 LOperand* index = UseTempRegister(instr->index());
2565 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index)); 2565 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index));
2566 } 2566 }
2567 2567
2568 2568
2569 } } // namespace v8::internal 2569 } } // namespace v8::internal
2570 2570
2571 #endif // V8_TARGET_ARCH_X64 2571 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/ia32/lithium-ia32.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698