Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Side by Side Diff: src/ia32/lithium-ia32.cc

Issue 13977019: Fix HConstant::InNewSpace() for parallel compilation. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/hydrogen-instructions.cc ('k') | src/x64/lithium-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2405 matching lines...) Expand 10 before | Expand all | Expand 10 after
2416 obj = instr->is_in_object() 2416 obj = instr->is_in_object()
2417 ? UseRegister(instr->object()) 2417 ? UseRegister(instr->object())
2418 : UseTempRegister(instr->object()); 2418 : UseTempRegister(instr->object());
2419 } else { 2419 } else {
2420 obj = needs_write_barrier_for_map 2420 obj = needs_write_barrier_for_map
2421 ? UseRegister(instr->object()) 2421 ? UseRegister(instr->object())
2422 : UseRegisterAtStart(instr->object()); 2422 : UseRegisterAtStart(instr->object());
2423 } 2423 }
2424 2424
2425 bool can_be_constant = instr->value()->IsConstant() && 2425 bool can_be_constant = instr->value()->IsConstant() &&
2426 !HConstant::cast(instr->value())->InNewSpace() && 2426 HConstant::cast(instr->value())->NotInNewSpace() &&
2427 !(FLAG_track_double_fields && instr->field_representation().IsDouble()); 2427 !(FLAG_track_double_fields && instr->field_representation().IsDouble());
2428 2428
2429 LOperand* val; 2429 LOperand* val;
2430 if (needs_write_barrier) { 2430 if (needs_write_barrier) {
2431 val = UseTempRegister(instr->value()); 2431 val = UseTempRegister(instr->value());
2432 } else if (can_be_constant) { 2432 } else if (can_be_constant) {
2433 val = UseRegisterOrConstant(instr->value()); 2433 val = UseRegisterOrConstant(instr->value());
2434 } else if (FLAG_track_fields && instr->field_representation().IsSmi()) { 2434 } else if (FLAG_track_fields && instr->field_representation().IsSmi()) {
2435 val = UseTempRegister(instr->value()); 2435 val = UseTempRegister(instr->value());
2436 } else { 2436 } else {
(...skipping 334 matching lines...) Expand 10 before | Expand all | Expand 10 after
2771 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { 2771 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
2772 LOperand* object = UseRegister(instr->object()); 2772 LOperand* object = UseRegister(instr->object());
2773 LOperand* index = UseTempRegister(instr->index()); 2773 LOperand* index = UseTempRegister(instr->index());
2774 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index)); 2774 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index));
2775 } 2775 }
2776 2776
2777 2777
2778 } } // namespace v8::internal 2778 } } // namespace v8::internal
2779 2779
2780 #endif // V8_TARGET_ARCH_IA32 2780 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/hydrogen-instructions.cc ('k') | src/x64/lithium-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698