Issue 13977018: Add Value::Is* methods for typed arrays and ArrayBuffer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13977018: Add Value::Is* methods for typed arrays and ArrayBuffer (Closed)

Created:
7 years, 7 months ago by Dmitry Lomov (no reviews)

Modified:
7 years, 7 months ago

Reviewers:
rossberg

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Add Value::Is* methods for typed arrays and ArrayBuffer R=rossberg BUG= Committed https://code.google.com/p/v8/source/detail?r=14506 Committed: https://code.google.com/p/v8/source/detail?r=14508

Patch Set 1 #

Total comments: 2

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+124 lines, -8 lines)			Patch
M	include/v8.h	View	1 chunk	+61 lines, -0 lines	0 comments	Download
M	src/api.cc	View	2 chunks	+38 lines, -8 lines	2 comments	Download
M	test/cctest/test-api.cc	View	1 chunk	+25 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

rossberg

LGTM https://codereview.chromium.org/13977018/diff/1/src/api.cc File src/api.cc (right): https://codereview.chromium.org/13977018/diff/1/src/api.cc#newcode2410 src/api.cc:2410: Nit: extra line https://codereview.chromium.org/13977018/diff/1/src/api.cc#newcode2423 src/api.cc:2423: Same here

7 years, 7 months ago (2013-04-30 13:46:48 UTC) #2

Dmitry Lomov (no reviews)

Committed https://code.google.com/p/v8/source/detail?r=14505. Closing bug

7 years, 7 months ago (2013-04-30 18:42:53 UTC) #3

Dmitry Lomov (no reviews)

7 years, 7 months ago (2013-04-30 18:53:34 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r14508 (presubmit successful).

Expand Messages | Collapse Messages