Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1397683003: Add doc/support/generate.sh (Closed)

Created:
5 years, 2 months ago by Mark Mentovai
Modified:
5 years, 2 months ago
Reviewers:
Robert Sesek, Bons
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

Add doc/support/generate.sh This script populates doc/generated. This directory is named in .gitignore on the master branch, but will not be ignored on the doc branch. The plan is to merge master into doc and run this script to generate and check in a new set of generated docs. BUG=crashpad:67 R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/3e5e5b570a7625808b2bbe3c8ccaae78add584a1

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address review comments #

Patch Set 3 : Manual → Man #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -20 lines) Patch
A doc/.gitignore View 1 chunk +1 line, -0 lines 0 comments Download
A doc/support/compat.sh View 1 chunk +39 lines, -0 lines 0 comments Download
A doc/support/generate.sh View 1 2 1 chunk +72 lines, -0 lines 0 comments Download
M doc/support/generate_asciidoc.sh View 2 chunks +2 lines, -20 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Mark Mentovai
5 years, 2 months ago (2015-10-08 18:21:11 UTC) #2
Bons
https://codereview.chromium.org/1397683003/diff/1/doc/support/generate.sh File doc/support/generate.sh (right): https://codereview.chromium.org/1397683003/diff/1/doc/support/generate.sh#newcode53 doc/support/generate.sh:53: <html> fun fact: html, head, and body tags are ...
5 years, 2 months ago (2015-10-08 18:27:06 UTC) #4
Bons
On 2015/10/08 18:27:06, Bons wrote: > https://codereview.chromium.org/1397683003/diff/1/doc/support/generate.sh > File doc/support/generate.sh (right): > > https://codereview.chromium.org/1397683003/diff/1/doc/support/generate.sh#newcode53 > ...
5 years, 2 months ago (2015-10-08 18:28:54 UTC) #5
Mark Mentovai
https://codereview.chromium.org/1397683003/diff/1/doc/support/generate.sh File doc/support/generate.sh (right): https://codereview.chromium.org/1397683003/diff/1/doc/support/generate.sh#newcode53 doc/support/generate.sh:53: <html> On 2015/10/08 18:27:06, Bons wrote: > fun fact: ...
5 years, 2 months ago (2015-10-08 18:31:57 UTC) #6
Robert Sesek
LGTM
5 years, 2 months ago (2015-10-08 18:36:53 UTC) #7
Mark Mentovai
5 years, 2 months ago (2015-10-08 18:38:24 UTC) #8
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
3e5e5b570a7625808b2bbe3c8ccaae78add584a1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698