Issue 1397673003: Add Gob encoding functions for Key.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1397673003: Add Gob encoding functions for Key. (Closed)

Created:
5 years, 2 months ago by iannucci

Modified:
5 years, 2 months ago

Reviewers:
dnj, Vadim Sh., estaab, M-A Ruel, tandrii(chromium)

CC:
chromium-reviews, infra-reviews+luci-gae_chromium.org

Base URL:
https://github.com/luci/gae.git@master

Target Ref:
refs/heads/master

Project:
luci-gae

Visibility:
Public.

More Reviews

Description

Add Gob encoding functions for Key. This is so that *Key can transparently be encoded in tumble mutation structs. R=dnj@chromium.org, estaab@chromium.org, maruel@chromium.org, tandrii@chromium.org, vadimsh@chromium.org BUG=533020 Committed: https://github.com/luci/gae/commit/80cb1c7de9414b21760aada5424ccd2576ee03b7

Patch Set 1 #

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -0 lines)			Patch
	M	service/datastore/key.go	View		1 chunk	+15 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1397673003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1397673003/1

5 years, 2 months ago (2015-10-10 17:47:49 UTC) #4

commit-bot: I haz the power

5 years, 2 months ago (2015-10-10 17:50:40 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://github.com/luci/gae/commit/80cb1c7de9414b21760aada5424ccd2576ee03b7

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages